gh-144533: Use pybuilddir.txt to find _sysconfigdata for WASI#144535
gh-144533: Use pybuilddir.txt to find _sysconfigdata for WASI#144535therohityadav wants to merge 1 commit into
Conversation
Sorry, something went wrong.
therohityadav
requested review from
brettcannon,
emmatyping and
savannahostrowski
as code owners
February 6, 2026 07:56
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
therohityadav
force-pushed
the
fix-wasi-build-144533
branch
2 times, most recently
from
035c77e to
b64935a
Compare
February 6, 2026 08:59
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
therohityadav
force-pushed
the
fix-wasi-build-144533
branch
from
b64935a to
0ecc19e
Compare
February 7, 2026 05:49
|
Hey there - thanks so much for working on this. However, based on the earlier discussion (#144535 (comment)), I've just merged a PR with a different approach so I'll close this. |
Sorry, something went wrong.
Reviewers
3 participants
_sysconfigdatafor the WASI build script #144533Use
pybuilddir.txtto find_sysconfigdatafor the WASI build script.The previous implementation hardcoded the path pattern to
build/lib.wasi-wasm32-{python_version}. This change makes the script more robust by reading the exact build directory frompybuilddir.txtif it exists. It falls back to the hardcoded path if the file is missing to ensure backward compatibility during early build stages.