◐ Shell
reader mode source ↗
Skip to content

bpo-37552 strptime/strftime return invalid results with UCRT version 17763.615#14460

Merged
pganssle merged 8 commits into
python:masterfrom
paulmon:buildbot_time
Jul 18, 2019
Merged

bpo-37552 strptime/strftime return invalid results with UCRT version 17763.615#14460
pganssle merged 8 commits into
python:masterfrom
paulmon:buildbot_time

Conversation

@paulmon

@paulmon paulmon commented Jun 28, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Skip tests that fail because of bug in MSVC UCRT failure when the default code page is cp65001.

@zooba

https://bugs.python.org/issue36511

@paulmon paulmon requested review from abalkin and pganssle as code owners June 28, 2019 22:41
@zooba

zooba commented Jun 28, 2019

Copy link
Copy Markdown
Member

These issues ought to be fixed in the next Windows update (end of year, about the time that 3.8 releases), though we may get a redistributable ucrtbase.dll sooner.

@bedevere-bot

bedevere-bot commented Jun 29, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@paulmon paulmon changed the title bpo-36511 skip strptime/strftime cp65001 failures Jul 10, 2019
@paulmon

paulmon commented Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Jul 10, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@zooba

zooba commented Jul 11, 2019

Copy link
Copy Markdown
Member

I believe this has been sufficiently handled, but I'll let @pganssle retract his review when he's ready. (And I'll poke him in person today to make sure he's ready ;) )

@paulmon

paulmon commented Jul 17, 2019

Copy link
Copy Markdown
Contributor Author

If the Azure Pipelines PR check passes, I think this is ready for additional feedback and/or merging.

@pganssle pganssle dismissed their stale review July 17, 2019 14:18

Comments addressed.

zware
zware approved these changes Jul 17, 2019
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

16 hidden items Load more…
@pganssle pganssle merged commit 9cd39b1 into python:master Jul 18, 2019
@miss-islington

miss-islington commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

Thanks @paulmon for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 18, 2019

Copy link
Copy Markdown

@pganssle: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2019
@paulmon @miss-islington
bpo-37552: Skip failing tests in strptime/strftime with UCRT version … …
c790038 
…17763.615 (pythonGH-14460)

A bug in MSVC UCRT version 17763.615 (which has been fixed in newer versions) is causing test failures in some strptime/strftime tests when the default code page is c65001. This change selectively skips the tests affected by this.
(cherry picked from commit 9cd39b1)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Jul 18, 2019

Copy link
Copy Markdown

GH-14839 is a backport of this pull request to the 3.8 branch.

@pganssle

pganssle commented Jul 18, 2019

Copy link
Copy Markdown
Member

@pganssle: Please replace # with GH- in the commit message next time. Thanks!

Noooo, I forgot I left that in the PR title. Serves me right for not using automerge.

@pganssle

pganssle commented Jul 18, 2019

Copy link
Copy Markdown
Member

Thanks for the PR and for promptly addressing comments, @paulmon!

miss-islington added a commit that referenced this pull request Jul 18, 2019
@miss-islington @paulmon
bpo-37552: Skip failing tests in strptime/strftime with UCRT version … …
652b667 
…17763.615 (GH-14460)

A bug in MSVC UCRT version 17763.615 (which has been fixed in newer versions) is causing test failures in some strptime/strftime tests when the default code page is c65001. This change selectively skips the tests affected by this.
(cherry picked from commit 9cd39b1)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
@paulmon

paulmon commented Jul 19, 2019

Copy link
Copy Markdown
Contributor Author

Thanks! all of the buildbot tests for Windows ARM32 have passed passed with only warnings since this was merged.

@paulmon paulmon deleted the buildbot_time branch August 12, 2019 20:06
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@paulmon @lisroach
bpo-37552: Skip failing tests in strptime/strftime with UCRT version … …
40b4933 
…17763.615 (python#14460)

A bug in MSVC UCRT version 17763.615 (which has been fixed in newer versions) is causing test failures in some strptime/strftime tests when the default code page is c65001. This change selectively skips the tests affected by this.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@paulmon @DinoV
bpo-37552: Skip failing tests in strptime/strftime with UCRT version … …
a6d894e 
…17763.615 (python#14460)

A bug in MSVC UCRT version 17763.615 (which has been fixed in newer versions) is causing test failures in some strptime/strftime tests when the default code page is c65001. This change selectively skips the tests affected by this.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@paulmon @websurfer5
bpo-37552: Skip failing tests in strptime/strftime with UCRT version … …
2dc3f6c 
…17763.615 (python#14460)

A bug in MSVC UCRT version 17763.615 (which has been fixed in newer versions) is causing test failures in some strptime/strftime tests when the default code page is c65001. This change selectively skips the tests affected by this.
@paulmon paulmon mannequin mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

@pganssle pganssle pganssle approved these changes

@zware zware

@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@paulmon @zooba @bedevere-bot @miss-islington @pganssle @zware @the-knights-who-say-ni