◐ Shell
reader mode source ↗
Skip to content

gh-141510, PEP 814: Add built-in frozendict type#144757

Merged
vstinner merged 16 commits into
python:mainfrom
vstinner:frozendict_base
Feb 17, 2026
Merged

gh-141510, PEP 814: Add built-in frozendict type#144757
vstinner merged 16 commits into
python:mainfrom
vstinner:frozendict_base

Conversation

@vstinner

@vstinner vstinner commented Feb 12, 2026 •
edited by hugovk
Loading

Copy link
Copy Markdown
Member

Add TYPE_FROZENDICT to the marshal module.

Add C API functions:

  • PyAnyDict_Check()
  • PyAnyDict_CheckExact()
  • PyFrozenDict_Check()
  • PyFrozenDict_CheckExact()
  • PyFrozenDict_New()

Add PyFrozenDict_Type C type.

📚 Documentation preview 📚: https://cpython-previews--144757.org.readthedocs.build/en/144757/c-api/dict.html#frozen-dictionary-objects

@vstinner
pythongh-141510, PEP 814: Add built-in frozendict type …
bde4379 
Add TYPE_FROZENDICT to the marshal module.

Add C API functions:

* PyAnyDict_Check()
* PyAnyDict_CheckExact()
* PyFrozenDict_Check()
* PyFrozenDict_CheckExact()
* PyFrozenDict_New()

Add PyFrozenDict_Type C type.
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2026
Closed
@vstinner vstinner marked this pull request as ready for review February 13, 2026 07:30
@vstinner

vstinner commented Feb 13, 2026

Copy link
Copy Markdown
Member Author

cc @corona10

@vstinner vstinner mentioned this pull request Feb 13, 2026
Closed
@vstinner
Fix doc warnings …
5e4a284 
Fix also indentation.
@corona10 corona10 self-requested a review February 13, 2026 10:07
@vstinner @hugovk
Apply suggestions from code review …
5c0c6f1 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
corona10
corona10 reviewed Feb 13, 2026
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

We should notice that frozendict is not subclass of dict to follow SC feedback

vstinner and others added 3 commits February 13, 2026 15:46
@vstinner @hugovk
Apply suggestion from @hugovk …
8d4ed14 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinner
Move the What's New entry …
c770613 
Document frozendict after lazy import.
@vstinner
Revert _PyDict_LoadBuiltinsFromGlobals() change
6dfec48
32 hidden items Load more…
@vstinner

vstinner commented Feb 13, 2026

Copy link
Copy Markdown
Member Author

We should notice that frozendict is not subclass of dict to follow SC feedback

Ah right, done.

@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 14, 2026
@bedevere-bot

bedevere-bot commented Feb 14, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 9101b1a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144757%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 14, 2026
@corona10

corona10 commented Feb 14, 2026

Copy link
Copy Markdown
Member

Let's wait build bot to pass the refleak test :)

benediktjohannes
benediktjohannes reviewed Feb 14, 2026
View reviewed changes

@benediktjohannes benediktjohannes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Nitpick: I know this does not primarily belong to the PR, but it's such a small change that a new PR wouldn't make sense for these small "typos".

@vstinner @adamchainz
Update Doc/library/stdtypes.rst …
e845b2b 
Co-authored-by: Adam Johnson <me@adamj.eu>
@vstinner

vstinner commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

Let's wait build bot to pass the refleak test :)

Tests passed successfully on Refleaks buildbots:

buildbot/AMD64 CentOS9 NoGIL Refleaks PR — Build done.
buildbot/AMD64 Fedora Stable Refleaks PR — Build done.
buildbot/AMD64 FreeBSD Refleaks PR — Build done.
buildbot/AMD64 RHEL8 Refleaks PR — Build done.
buildbot/AMD64 Windows11 Refleaks PR — Build done.
buildbot/ARM64 MacOS M1 Refleaks NoGIL PR — Build done.
buildbot/PPC64LE Fedora Stable Refleaks PR — Build done.
buildbot/PPC64LE RHEL8 Refleaks PR — Build done.
buildbot/s390x Fedora Stable Refleaks PR — Build done.
buildbot/s390x RHEL8 Refleaks PR — Build done.
buildbot/s390x RHEL9 Refleaks PR — Build done.

vstinner and others added 2 commits February 16, 2026 13:01
@vstinner @hugovk
Apply suggestions from code review …
3d08f46 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinner
doc: use sentence case for headers …
258b3df 
Add also a title in Doc/library/stdtypes.rst.
@vstinner

vstinner commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

@hugovk: I modified a few more titles in the C API doc and the Python doc to use sentence case for headers.

corona10
corona10 approved these changes Feb 16, 2026
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm with current implementations , I will soon create PRs for removing unneeded overhead from my side.

sergey-miryanov
sergey-miryanov reviewed Feb 16, 2026
View reviewed changes

@sergey-miryanov sergey-miryanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Couple of nitpicks.

vstinner and others added 2 commits February 16, 2026 21:33
@vstinner
Add tests on repr(frozendict)
09abcf5
@vstinner @hugovk
Apply suggestions from code review …
3653eeb 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinner @benediktjohannes
Apply suggestions from code review …
5bc207a 
Co-authored-by: Benedikt Johannes <benedikt.johannes.hofer@gmail.com>
Hide details View details @vstinner vstinner merged commit 696cdfc into python:main Feb 17, 2026
47 checks passed
@vstinner vstinner deleted the frozendict_base branch February 17, 2026 09:54
@vstinner

vstinner commented Feb 17, 2026

Copy link
Copy Markdown
Member Author

I merged my PR. Thank you very much for all your reviews!

@savannahostrowski savannahostrowski mentioned this pull request Feb 18, 2026
Closed
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@vstinner @hugovk
@adamchainz @benediktjohannes @brijkapadia
pythongh-141510, PEP 814: Add built-in frozendict type (python#144757) …
1044beb 
Add TYPE_FROZENDICT to the marshal module.

Add C API functions:

* PyAnyDict_Check()
* PyAnyDict_CheckExact()
* PyFrozenDict_Check()
* PyFrozenDict_CheckExact()
* PyFrozenDict_New()

Add PyFrozenDict_Type C type.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Adam Johnson <me@adamj.eu>
Co-authored-by: Benedikt Johannes <benedikt.johannes.hofer@gmail.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@vstinner @hugovk
@adamchainz @benediktjohannes @ljfp
pythongh-141510, PEP 814: Add built-in frozendict type (python#144757) …
fa77761 
Add TYPE_FROZENDICT to the marshal module.

Add C API functions:

* PyAnyDict_Check()
* PyAnyDict_CheckExact()
* PyFrozenDict_Check()
* PyFrozenDict_CheckExact()
* PyFrozenDict_New()

Add PyFrozenDict_Type C type.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Adam Johnson <me@adamj.eu>
Co-authored-by: Benedikt Johannes <benedikt.johannes.hofer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov left review comments

@hugovk hugovk hugovk left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@corona10 corona10

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@AA-Turner AA-Turner

+2 more reviewers

@adamchainz adamchainz adamchainz left review comments

@benediktjohannes benediktjohannes benediktjohannes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vstinner @bedevere-bot @corona10 @sergey-miryanov @adamchainz @hugovk @kumaraditya303 @benediktjohannes