◐ Shell
reader mode source ↗
Skip to content

bpo-30266: support "= None" pattern in AbstractContextManager#1448

Merged
gvanrossum merged 7 commits into
python:masterfrom
JelleZijlstra:acmnone
Jun 9, 2017
Merged

bpo-30266: support "= None" pattern in AbstractContextManager#1448
gvanrossum merged 7 commits into
python:masterfrom
JelleZijlstra:acmnone

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 4, 2017

Copy link
Copy Markdown
Member

No description provided.

@mention-bot

mention-bot commented May 4, 2017

Copy link
Copy Markdown

@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @berkerpeksag and @Yhg1s to be potential reviewers.

berkerpeksag
berkerpeksag requested changes May 4, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Could you please add a note to Misc/NEWS?

@JelleZijlstra

JelleZijlstra commented May 5, 2017

Copy link
Copy Markdown
Member Author

Done, thanks for the review.

@ilevkivskyi

ilevkivskyi commented May 12, 2017

Copy link
Copy Markdown
Member

It looks like a fourth merge is required...

@gvanrossum

gvanrossum commented Jun 9, 2017

Copy link
Copy Markdown
Member

Pinging @berkerpeksag -- is this now to your satisfaction? Could we get it in 3.6.3? (I.e. before Monday June 12.)

@gvanrossum

gvanrossum commented Jun 9, 2017

Copy link
Copy Markdown
Member

This seems simple enough, I'm merging it.

@gvanrossum gvanrossum merged commit 57161aa into python:master Jun 9, 2017
@gvanrossum

gvanrossum commented Jun 9, 2017

Copy link
Copy Markdown
Member

@Mariatta Can you help backporting this to 3.6?

@Mariatta Mariatta self-assigned this Jun 9, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 10, 2017
@JelleZijlstra @Mariatta
[3.6] bpo-30266: support "= None" pattern in AbstractContextManager (p… …
f16a3fc 
…ythonGH-1448)

contextlib.AbstractContextManager now supports anti-registration
by setting __enter__ = None or __exit__ = None, following the pattern
introduced in bpo-25958..
(cherry picked from commit 57161aa)
@Mariatta Mariatta mentioned this pull request Jun 10, 2017
Merged
Mariatta added a commit that referenced this pull request Jun 10, 2017
@Mariatta
bpo-30266: support "= None" pattern in AbstractContextManager (GH-1448)… …
753422f 
… (GH-2054)

contextlib.AbstractContextManager now supports anti-registration
by setting __enter__ = None or __exit__ = None, following the pattern
introduced in bpo-25958..
(cherry picked from commit 57161aa)
@Mariatta Mariatta removed their assignment Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag requested changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JelleZijlstra @mention-bot @ilevkivskyi @gvanrossum @berkerpeksag @Mariatta @the-knights-who-say-ni