gh-141510: Fix copy.deepcopy() for recursive frozendict#145027
Conversation
eendebakpt
left a comment
There was a problem hiding this comment.
Good catch!
Sorry, something went wrong.
|
After adding the pickle support we may be able to remove the special deepcopy code. |
Sorry, something went wrong.
I propose merging #144967 PR first (once it will be approved), and then rework this PR. See also @serhiy-storchaka's comment on the pickle PR:
We can add more tests in this deepcopy PR. |
Sorry, something went wrong.
I merged main into this branch to retrieve the pickle change. If I remove |
Sorry, something went wrong.
Hmm, I thought it is just an optimization. I wonder if |
Sorry, something went wrong.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍 (But maybe add few more assertions?)
Sorry, something went wrong.
646bd86
into
python:main
Feb 21, 2026
|
Merged, thanks for the exhaustive review. |
Sorry, something went wrong.
edited by bedevere-app
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.