gh-145119: Allow frozendict to be assigned to instance __dict__#145123
gh-145119: Allow frozendict to be assigned to instance __dict__#145123mohsinm-dev wants to merge 2 commits into
Conversation
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b702cf72b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
mohsinm-dev
force-pushed
the
gh-145119-frozendict-instance-dict
branch
from
6b702cf to
8d6ec8d
Compare
February 22, 2026 19:22
|
In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits. When the PR is merged, everything will be squashed into a single commit. |
Sorry, something went wrong.
I extracted these changes from your PR and created a new PR based on it: PR gh-145564. |
Sorry, something went wrong.
|
The attached issue was closed. |
Sorry, something went wrong.
Reviewers
4 participants
Allow
frozendict(and its subclasses) to be assigned to an instance's__dict__, enabling immutable instances.Changes:
_PyObject_SetDict: acceptfrozendictviaPyAnyDict_Check_PyDict_SetItem_LockHeld: raiseTypeErroron set/delete instead ofSystemErrorobject___dir___impl: convertfrozendictto a mutable dict for merging