◐ Shell
reader mode source ↗
Skip to content

gh-145234: Normalize decoded CR in string tokenizer#145281

Merged
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-145234
Feb 27, 2026
Merged

gh-145234: Normalize decoded CR in string tokenizer#145281
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-145234

Conversation

@pablogsal

@pablogsal pablogsal commented Feb 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2026
Closed
lysnikolaou
lysnikolaou approved these changes Feb 27, 2026
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!

Hide details View details @pablogsal pablogsal merged commit 98b1e51 into python:main Feb 27, 2026
51 checks passed
@pablogsal pablogsal deleted the gh-145234 branch February 27, 2026 12:44
@miss-islington-app

miss-islington-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2026
@pablogsal @miss-islington
pythongh-145234: Normalize decoded CR in string tokenizer (pythonGH-1… …
0142d1c 
…45281)

(cherry picked from commit 98b1e51)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@miss-islington-app

miss-islington-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 98b1e519273dd28ce73cc21a636e2f3a937e1f8c 3.13

@bedevere-app

bedevere-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

GH-145310 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 27, 2026
pablogsal added a commit that referenced this pull request Feb 27, 2026
@miss-islington @pablogsal
[3.14] gh-145234: Normalize decoded CR in string tokenizer (GH-145281) ( …
f04aefa 
#145310)

gh-145234: Normalize decoded CR in string tokenizer (GH-145281)
(cherry picked from commit 98b1e51)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app

bedevere-app Bot commented Feb 27, 2026

Copy link
Copy Markdown

GH-145312 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 27, 2026
pablogsal added a commit to pablogsal/cpython that referenced this pull request Feb 27, 2026
@pablogsal
[3.13] pythongh-145234: Normalize decoded CR in string tokenizer (pyt… …
cf5c995 
…honGH-145281)

(cherry picked from commit 98b1e51)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsal pablogsal restored the gh-145234 branch February 28, 2026 01:38
pablogsal added a commit that referenced this pull request Feb 28, 2026
@pablogsal
[3.13] gh-145234: Normalize decoded CR in string tokenizer (GH-145281) ( …
2daece9 
#145312)
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@pablogsal @brijkapadia
pythongh-145234: Normalize decoded CR in string tokenizer (python#145281 …
aca1c73 
)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@pablogsal @ljfp
pythongh-145234: Normalize decoded CR in string tokenizer (python#145281 …
90949fa 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal @lysnikolaou