◐ Shell
reader mode source ↗
Skip to content

gh-145241: specialize SyntaxError for single trailing-comma with item#145282

Merged
pablogsal merged 5 commits into
python:mainfrom
pablogsal:gh-145241-with-trailing-comma-news
Feb 28, 2026
Merged

gh-145241: specialize SyntaxError for single trailing-comma with item#145282
pablogsal merged 5 commits into
python:mainfrom
pablogsal:gh-145241-with-trailing-comma-news

Conversation

@pablogsal

@pablogsal pablogsal commented Feb 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2026
Closed
@pablogsal pablogsal force-pushed the gh-145241-with-trailing-comma-news branch from 3433bc5 to 4994e57 Compare February 26, 2026 21:46
johnslavik
johnslavik requested changes Feb 26, 2026
View reviewed changes

@johnslavik johnslavik left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks! I've researched this a bit more, and I think we can make this even better :-)
Sorry for the resulting back-and-forth and not enough research in the issue.

The syntax error happens every time the last with item (could be one or could be multiple overall) has a bare trailing comma and items aren't parenthesized.

We'd want to add cases with multiple items as well and adapt the error message accordingly. I've added suggestions ready for you to apply. Please feel free to pick better phrasing though.

PS Also suggested using RAISE_SYNTAX_ERROR_KNOWN_LOCATION so that the caret ^ points at the faulty trailing comma (right now the caret points at the colon).

pablogsal and others added 3 commits February 28, 2026 01:46
@pablogsal @johnslavik
Update Lib/test/test_syntax.py …
af61c31 
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@pablogsal @johnslavik
Update Grammar/python.gram …
7a6fcf1 
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@pablogsal
Update parser
16e0169
@pablogsal pablogsal enabled auto-merge (squash) February 28, 2026 01:47
@pablogsal @johnslavik
Update Misc/NEWS.d/next/Core_and_Builtins/2026-02-26-18-00-00.gh-issu… …
0aeb220 
…e-145241.hL2k9Q.rst

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Hide details View details @pablogsal pablogsal merged commit 09e8c38 into python:main Feb 28, 2026
47 checks passed
@pablogsal pablogsal deleted the gh-145241-with-trailing-comma-news branch February 28, 2026 02:24
@johnslavik johnslavik added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 28, 2026
@miss-islington-app

miss-islington-app Bot commented Feb 28, 2026

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Feb 28, 2026

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Feb 28, 2026

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 09e8c382312b145b710dca7072ff2e13fe8c09ab 3.13

@miss-islington-app

miss-islington-app Bot commented Feb 28, 2026

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 09e8c382312b145b710dca7072ff2e13fe8c09ab 3.14

@johnslavik

johnslavik commented Feb 28, 2026

Copy link
Copy Markdown
Member

Uhh no, not worth it maybe.

@johnslavik johnslavik removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 28, 2026
@johnslavik

johnslavik commented Feb 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I've requested backports because #142236 (comment), but I'm giving up on that in this case. Too much effort.

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@pablogsal @johnslavik @brijkapadia
pythongh-145241: specialize SyntaxError for single trailing-comma wit… …
0d13a6e 
…h item (python#145282)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@pablogsal @johnslavik @ljfp
pythongh-145241: specialize SyntaxError for single trailing-comma wit… …
172eb81 
…h item (python#145282)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnslavik johnslavik johnslavik approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal @johnslavik