◐ Shell
reader mode source ↗
Skip to content

Typo fix in file Include/object.h#14556

Merged
miss-islington merged 1 commit into
python:masterfrom
hansrajdas:typo-fix
Jul 5, 2019
Merged

Typo fix in file Include/object.h#14556
miss-islington merged 1 commit into
python:masterfrom
hansrajdas:typo-fix

Conversation

@hansrajdas

@hansrajdas hansrajdas commented Jul 2, 2019

Copy link
Copy Markdown
Contributor
  • accross -> across
  • Extra space removed in comment

@jdemeyer

jdemeyer commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

FYI: #4944 (comment)

@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Jul 5, 2019
@miss-islington miss-islington merged commit 10e5c66 into python:master Jul 5, 2019
@miss-islington

miss-islington commented Jul 5, 2019

Copy link
Copy Markdown
Contributor

Thanks @hansrajdas for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 5, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@brettcannon

brettcannon commented Jul 5, 2019

Copy link
Copy Markdown
Member

Thanks!

@hansrajdas

hansrajdas commented Aug 16, 2019

Copy link
Copy Markdown
Contributor Author

This PR is not backported to 3.8, there was some error while backporting (#14556 (comment)). Is there something i can do for this?

@brettcannon

brettcannon commented Aug 21, 2019

Copy link
Copy Markdown
Member

@hansrajdas looks like a bot hiccup. It isn't really that important for a spelling fix so I'm not too bothered if it doesn't get backported.

@hansrajdas

hansrajdas commented Aug 22, 2019

Copy link
Copy Markdown
Contributor Author

Ok, Thanks for writing back!

@hansrajdas hansrajdas deleted the typo-fix branch August 22, 2019 20:38
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@hansrajdas @lisroach
Typo fix in file Include/object.h (pythonGH-14556) …
06fd1dd 
* accross -> across
* Extra space removed in comment
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@hansrajdas @DinoV
Typo fix in file Include/object.h (pythonGH-14556) …
6e17e87 
* accross -> across
* Extra space removed in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@jdemeyer jdemeyer jdemeyer approved these changes

Assignees

No one assigned

Labels

skip issue skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hansrajdas @jdemeyer @miss-islington @brettcannon @the-knights-who-say-ni @bedevere-bot