{{ message }}
gh-146075: Prevent crash in functools.partial() from malformed str subclass#146078
Merged
encukou merged 3 commits intoMar 18, 2026
Merged
gh-146075: Prevent crash in functools.partial() from malformed str subclass#146078encukou merged 3 commits into
functools.partial() from malformed str subclass#146078encukou merged 3 commits into
Conversation
Contributor
Sorry, something went wrong.
In `partial_vectorcall`, an error returned by `PyDict_Contains` was considered to be a truthy value. Now, the error is handled appropriately.
skirpichev
approved these changes
Mar 17, 2026
skirpichev
left a comment
skirpichev
left a comment
Member
There was a problem hiding this comment.
LGTM
Test failures look unrelated.
Sorry, something went wrong.
kumaraditya303
approved these changes
Mar 18, 2026
Hide details
View details
encukou
merged commit
encukou
merged commit 6486211
into
python:main
Mar 18, 2026
93 of 99 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
In
partial_vectorcall, an error returned byPyDict_Containswas considered to be a truthy value. Now, the error is handled appropriately.functools.partialusing astrsubclass that raises on__eq__#146075