You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Thanks for the fix @sergey-miryanov! All looks good to me.
My apologies for not considering that args was mutable in the first implementation!
It's a pity that we don't preserve the list-like repr (ExceptionGroup('msg', [ValueError()])) in this case. But mutating the args to something without an exceptions list in it seems like a weird enough use case that we can just do this?
If this is something that people actually do (why?), we could just set the self->excs_str in all cases, but that can be quite inefficient and I'd really prefer not to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Fix segfault when calling repr for BaseExceptionGroup.
cc @dr-carlos
BaseExceptionGroup_repr#146096