◐ Shell
reader mode source ↗
Skip to content

[3.14] gh-146056: Fix repr() for lists and tuples containing NULLs (GH-146129)#146155

Merged
serhiy-storchaka merged 4 commits into
python:3.14from
serhiy-storchaka:backport-0f2246b-3.14
Mar 22, 2026
Merged

[3.14] gh-146056: Fix repr() for lists and tuples containing NULLs (GH-146129)#146155
serhiy-storchaka merged 4 commits into
python:3.14from
serhiy-storchaka:backport-0f2246b-3.14

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 19, 2026

Copy link
Copy Markdown
Member

pythonGH-146129)

(cherry picked from commit 0f2246b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka serhiy-storchaka changed the title [3.14] gh-146056: Fix list.__repr__() for lists containing NULLs (GH-146129) Mar 20, 2026

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

Ok, let's do that, accept NULL in PyUnicodeWriter_WriteRepr(). At least, the API change is now documented.

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

Note that no versionchanged was added for the API change in #146201 (I do not think that it is needed).

Hide details View details @serhiy-storchaka serhiy-storchaka merged commit 7965133 into python:3.14 Mar 22, 2026
51 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the backport-0f2246b-3.14 branch March 22, 2026 07:25
@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 796513306fdc1184452ea644b485f83511f39528 3.13

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 22, 2026
…LLs (pythonGH-146129) (pythonGH-146155)

(cherry picked from commit 0f2246b)
(cherry picked from commit 7965133)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 22, 2026
…GH-146129) (pythonGH-146155)

(cherry picked from commit 0f2246b)
(cherry picked from commit 7965133)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Mar 22, 2026

Copy link
Copy Markdown

GH-146271 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 22, 2026
serhiy-storchaka added a commit that referenced this pull request Mar 22, 2026
…H-146155) (GH-146271)

(cherry picked from commit 0f2246b)
(cherry picked from commit 7965133)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants