◐ Shell
reader mode source ↗
Skip to content

gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression failure#146246

Merged
serhiy-storchaka merged 6 commits into
python:mainfrom
Wulian233:initconfig
Mar 25, 2026
Merged

gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression failure#146246
serhiy-storchaka merged 6 commits into
python:mainfrom
Wulian233:initconfig

Conversation

@Wulian233

@Wulian233 Wulian233 commented Mar 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Mar 21, 2026
Closed
@Wulian233

Wulian233 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Could you please help review this PR? Thank you very much!

@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 24, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Mar 25, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. 👍

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) March 25, 2026 18:39
Hide details View details @serhiy-storchaka serhiy-storchaka merged commit 9343518 into python:main Mar 25, 2026
49 checks passed
@miss-islington-app

miss-islington-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

Thanks @Wulian233 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2026
@Wulian233 @miss-islington
pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres… …
760194e 
…sion failure (pythonGH-146246)

(cherry picked from commit 9343518)

Co-authored-by: Wulian233 <1055917385@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2026
@Wulian233 @miss-islington
pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres… …
e71c242 
…sion failure (pythonGH-146246)

(cherry picked from commit 9343518)

Co-authored-by: Wulian233 <1055917385@qq.com>
@bedevere-app

bedevere-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

GH-146432 is a backport of this pull request to the 3.14 branch.

@bedevere-app

bedevere-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

GH-146433 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 25, 2026
serhiy-storchaka pushed a commit that referenced this pull request Mar 25, 2026
@miss-islington @Wulian233
[3.13] gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expre… …
fc4b422 
…ssion failure (GH-146246) (GH-146433)

(cherry picked from commit 9343518)

Co-authored-by: Wulian233 <1055917385@qq.com>
@Wulian233 Wulian233 deleted the initconfig branch March 25, 2026 22:24
serhiy-storchaka pushed a commit that referenced this pull request Mar 27, 2026
@miss-islington @Wulian233
[3.14] gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expre… …
4d61fd6 
…ssion failure (GH-146246) (GH-146432)

(cherry picked from commit 9343518)

Co-authored-by: Wulian233 <1055917385@qq.com>
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@Wulian233 @clin1234
pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres… …
41d4bf9 
…sion failure (pythonGH-146246)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Wulian233 @ljfp
pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres… …
f383929 
…sion failure (pythonGH-146246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wulian233 @serhiy-storchaka