gh-146388: Add null check for sym_new(ctx) in make_bottom#146389
gh-146388: Add null check for sym_new(ctx) in make_bottom#146389Fidget-Spinner merged 7 commits into
sym_new(ctx) in make_bottom#146389Conversation
Sorry, something went wrong.
A0su
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
March 24, 2026 18:14
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
|
I think this fix is simple enough which doesn't requires a test, but the news entry is required. Can you add it follow the Dev Guide? https://devguide.python.org/getting-started/pull-request-lifecycle/#updating-news-and-what-s-new-in-python |
Sorry, something went wrong.
Co-authored-by: AN Long <aisk@users.noreply.github.com>
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I'm not sure that the NEWS entry is worth it, it's a corner case which is unlikely to occur in practice, no?
Sorry, something went wrong.
Fidget-Spinner
merged commit c8ee196
into
python:main
Mar 27, 2026
Reviewers
5 participants
optimizer_symbols.c: make_bottom NULL deref when arena full
sym_new(ctx)at line 1535 can return NULL when the type arena is full. Result immediately dereferenced without check. Every othersym_newcall site checks for NULL.This is a sub-issue of #146102 with gist details
optimizer_symbols.c:make_bottomNULL deref when arena full #146388