◐ Shell
reader mode source ↗
Skip to content

gh-146004: fix test_args_from_interpreter_flags#146580

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
chris-eibl:fix_test_args_from_interpreter_flags
Mar 29, 2026
Merged

gh-146004: fix test_args_from_interpreter_flags#146580
kumaraditya303 merged 1 commit into
python:mainfrom
chris-eibl:fix_test_args_from_interpreter_flags

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Mar 28, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Windows build bots are failing with

Warning -- files was modified by test_support
Warning --   Before: []
Warning --   After:  ['tmp/']

@chris-eibl
fix test_args_from_interpreter_flags …
4ecea2e 
Warning -- files was modified by test_support
Warning --   Before: []
Warning --   After:  ['tmp/']
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 28, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 28, 2026
Closed
@chris-eibl chris-eibl added skip news tests Tests in the Lib/test dir and removed tests Tests in the Lib/test dir awaiting review labels Mar 28, 2026
@bedevere-app bedevere-app Bot added the label Mar 28, 2026
@chris-eibl

chris-eibl commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

!buildbot Windows

@bedevere-bot

bedevere-bot commented Mar 28, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @chris-eibl for commit 4ecea2e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146580%2Fmerge

The command will test the builders whose names match following regular expression: Windows

The builders matched are:

  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows PGO NoGIL PR
  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows PGO NoGIL Tailcall PR
  • AMD64 Windows11 Bigmem PR
  • AMD64 Windows PGO PR
  • ARM64 Windows Non-Debug PR
  • ARM64 Windows PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Windows PGO Tailcall PR
  • AMD64 Windows10 PR

@chris-eibl

chris-eibl commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

Ups, that was coincidally. Just triggered the Windows bots ...

@picnixz picnixz added the needs backport to 3.14 bugs and security fixes label Mar 28, 2026
@picnixz picnixz mentioned this pull request Mar 28, 2026
Merged
Hide details View details @kumaraditya303 kumaraditya303 merged commit 1af025d into python:main Mar 29, 2026
69 checks passed
@miss-islington-app

miss-islington-app Bot commented Mar 29, 2026

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2026
@chris-eibl @miss-islington
pythongh-146004: fix test_args_from_interpreter_flags on windows (pyt… …
3ab87af 
…honGH-146580)

(cherry picked from commit 1af025d)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Mar 29, 2026

Copy link
Copy Markdown

GH-146585 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 29, 2026
kumaraditya303 pushed a commit that referenced this pull request Mar 29, 2026
@miss-islington @chris-eibl
[3.14] gh-146004: fix test_args_from_interpreter_flags on windows (GH… …
525f8e4 
…-146580) (#146585)

gh-146004: fix test_args_from_interpreter_flags on windows (GH-146580)
(cherry picked from commit 1af025d)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Mar 29, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.x (tier-3) has failed when building commit 1af025d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1613/builds/3046) and take a look at the build logs.
  4. Check if the failure is related to this commit (1af025d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1613/builds/3046

Failed tests:

  • test_datetime

Test leaking resources:

  • test_events: memory blocks
  • test_events: references

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 11705), raddr=('127.0.0.1', 11706)>
Task was destroyed but it is pending!
task: <Task pending name='Task-1508' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:219> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x83f552ed0>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 877, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('127.0.0.1', 46439), raddr=('127.0.0.1', 46440)>
Task was destroyed but it is pending!
task: <Task pending name='Task-3623' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:219> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x844219a90>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 877, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=10>
k

maurycy added a commit to maurycy/cpython that referenced this pull request Mar 30, 2026
@maurycy
Merge remote-tracking branch 'upstream/main' into tachyon-ndjson-kole… …
6a0ea81 
…ktor

* upstream/main: (119 commits)
  pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845)
  pythongh-146558: JIT optimize dict access for objects with known hash (python#146559)
  pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570)
  pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)
  pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593)
  pythongh-138122: Add differential flame graph (python#145785)
  pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417)
  pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628)
  pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
  pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624)
  pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597)
  pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557)
  pythongh-146579: _zstd: Fix decompression options dict error message (python#146577)
  pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085)
  pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573)
  pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569)
  pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472)
  pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580)
  pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004)
  pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532)
  ...
@chris-eibl chris-eibl deleted the fix_test_args_from_interpreter_flags branch March 30, 2026 19:10
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@chris-eibl @clin1234
pythongh-146004: fix test_args_from_interpreter_flags on windows (pyt… …
080801e 
…hon#146580)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@chris-eibl @ljfp
pythongh-146004: fix test_args_from_interpreter_flags on windows (pyt… …
56ca205 
…hon#146580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chris-eibl @bedevere-bot @gpshead @picnixz @kumaraditya303