◐ Shell
reader mode source ↗
Skip to content

gh-146636: PEP 803: Reference documentation#148013

Merged
encukou merged 12 commits into
python:mainfrom
encukou:803-docs
Apr 16, 2026
Merged

gh-146636: PEP 803: Reference documentation#148013
encukou merged 12 commits into
python:mainfrom
encukou:803-docs

Conversation

@encukou

@encukou encukou commented Apr 2, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added the label Apr 2, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 2, 2026
Open
9 tasks
ZeroIntensity
ZeroIntensity reviewed Apr 2, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Congrats on the PEP acceptance :)

Mostly editorial comments from me. The content generally looks good.

2 hidden conversations Load more…
@StanFromIreland

StanFromIreland commented Apr 2, 2026

Copy link
Copy Markdown
Member

The new check caught removals: https://github.com/python/cpython/actions/runs/23907059205/job/69719041532?pr=148013 (and on your PR out of everyone's ;-)

hugovk
hugovk reviewed Apr 3, 2026
View reviewed changes
2 hidden conversations Load more…
ngoldbaum
ngoldbaum reviewed Apr 3, 2026
View reviewed changes

@ngoldbaum ngoldbaum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for putting this together! I left a few comments inline, please take them or leave them as you see fit.

encukou and others added 2 commits April 6, 2026 12:06
@encukou @hugovk
Apply suggestions from code review …
30d97b1 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@encukou
Respond to reviews
e7e102a
@encukou encukou mentioned this pull request Apr 7, 2026
Open
@encukou encukou requested a review from StanFromIreland as a code owner April 8, 2026 07:32
@clin1234 clin1234 mentioned this pull request Apr 12, 2026
Closed
@encukou

encukou commented Apr 14, 2026

Copy link
Copy Markdown
Member Author

I've addressed the comments; does anyone want to re-review?
If not I'll merge around Thursday.

Hide details View details @encukou encukou merged commit 0fcf2b7 into python:main Apr 16, 2026
39 checks passed
@encukou encukou deleted the 803-docs branch April 16, 2026 12:17
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@encukou @hugovk @ljfp
pythongh-146636: PEP 803: Reference documentation (pythonGH-148013) …
cedb210 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@ngoldbaum ngoldbaum

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently is a code owner

@AA-Turner AA-Turner

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner

+2 more reviewers

@da-woods da-woods da-woods left review comments

@AIdjis AIdjis AIdjis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@encukou @StanFromIreland @hugovk @ngoldbaum @da-woods @ZeroIntensity @AIdjis