{{ message }}
bpo-37609: Add device path support in ntpath splitdrive#14841
Closed
nsiregar wants to merge 5 commits into
Closed
Conversation
Contributor
Sorry, something went wrong.
nsiregar
force-pushed
the
bpo-37609-support-unc-device-path-ntpath-splitdrive
branch
from
f69464e to
589e045
Compare
July 19, 2019 17:28
nsiregar
force-pushed
the
bpo-37609-support-unc-device-path-ntpath-splitdrive
branch
from
e92813b to
eb4e996
Compare
August 24, 2019 09:26
Member
|
Sorry for not seeing this earlier, I have a few general suggestions:
|
Sorry, something went wrong.
eryksun
reviewed
Sep 12, 2019
Contributor
Author
|
working on it |
Sorry, something went wrong.
Contributor
|
For an alternate and more complete implementation, see the splitdrive.py file that I attached to bpo-37609. |
Sorry, something went wrong.
Contributor
|
I managed to fix the issue elsewhere (in #91882), so I'm going to close this PR, but thank you very much for taking a look at it! :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewer
9 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Add device path support in
ntpath.splitdrivehttps://bugs.python.org/issue37609