◐ Shell
reader mode source ↗
Skip to content

Add missing space to warning message#14915

Merged
rhettinger merged 1 commit into
python:masterfrom
The-Compiler:patch-1
Aug 22, 2019
Merged

Add missing space to warning message#14915
rhettinger merged 1 commit into
python:masterfrom
The-Compiler:patch-1

Conversation

@The-Compiler

@The-Compiler The-Compiler commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

This was introduced in GH-13409 when changing the message text.

cc @Carreau

This should probably go to the 3.8 branch as well?

@The-Compiler
Add missing space to warning message …
1c30e0d 
This was introduced in GH-13409 when changing the message text.
@The-Compiler The-Compiler requested a review from rhettinger as a code owner July 23, 2019 11:21
@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 23, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@The-Compiler The-Compiler mentioned this pull request Jul 23, 2019
Closed
@Carreau

Carreau commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

Oops, thanks !

@aeros

aeros commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

@The-Compiler Thanks for the contribution! Yes, this should be backported to 3.8 as well since the space is also missing on that branch.

@The-Compiler

The-Compiler commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

FWIW I signed the CLA right after opening this PR, but looks like it hasn't been received yet?

@aeros

aeros commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

@The-Compiler CLA approval usually takes around 24 hours. Sometimes though you have to manually refresh the status on GitHub, use the link from @the-knights-who-say-ni: check yourself.

@The-Compiler

The-Compiler commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

I'm aware - it's been three days and the checker still says "The-Compiler has not signed CLA".

@aeros

aeros commented Jul 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@The-Compiler The only other option that I'm aware of is sending an email to contributors@python.org

@The-Compiler

The-Compiler commented Jul 29, 2019

Copy link
Copy Markdown
Contributor Author

@aeros167 Thanks, that helped - turns out I somehow have two bugs.python.org accounts ("The-Compiler" from 2012, "The Compiler" from 2014) but never noticed, and they accidentally marked the wrong one.

Anything else I need to do at this point? I don't think this needs a news item or issue number FWIW.

@aeros

aeros commented Jul 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@The-Compiler At this point, it's just waiting for a core dev review, they can add a skip news and skip issue label for you.

@rhettinger rhettinger merged commit c4106af into python:master Aug 22, 2019
@miss-islington

miss-islington commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

Thanks @The-Compiler for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Aug 22, 2019

Copy link
Copy Markdown

GH-15379 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2019
@The-Compiler @miss-islington
Add missing space to warning message (pythonGH-14915) …
64fbd5a 
This typo was introduced in pythonGH-13409 when changing the message text.
(cherry picked from commit c4106af)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
rhettinger pushed a commit that referenced this pull request Aug 22, 2019
@miss-islington @The-Compiler @rhettinger
Add missing space to warning message (GH-14915) (GH-15379) …
8ede967 
This typo was introduced in GH-13409 when changing the message text.
(cherry picked from commit c4106af)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@The-Compiler The-Compiler deleted the patch-1 branch August 22, 2019 06:50
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@The-Compiler @lisroach
Add missing space to warning message (pythonGH-14915) …
f91e866 
This typo was introduced in pythonGH-13409 when changing the message text.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@The-Compiler @DinoV
Add missing space to warning message (pythonGH-14915) …
37c7872 
This typo was introduced in pythonGH-13409 when changing the message text.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@The-Compiler @websurfer5
Add missing space to warning message (pythonGH-14915) …
3511772 
This typo was introduced in pythonGH-13409 when changing the message text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

+2 more reviewers

@aeros aeros

@Carreau Carreau Carreau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@The-Compiler @the-knights-who-say-ni @Carreau @aeros @miss-islington @bedevere-bot @rhettinger