bpo-29446: IDLE -- add explicit imports#14919
Conversation
Stop depending on tkinter import *.
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Sorry, something went wrong.
Stop depending on tkinter import *. (cherry picked from commit c6fd6c8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Stop depending on tkinter import *. (cherry picked from commit c6fd6c8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot x86 Windows7 3.7 has failed when building commit aee260f. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/111/builds/1188 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Tests result: FAILURE then ENV CHANGED == 384 tests OK. 10 slowest tests:
1 test altered the execution environment: 31 tests skipped: 1 re-run test: Total duration: 56 min 48 sec Click to see traceback logsTraceback (most recent call last):
File "D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\lib\idlelib\idle_test\test_tooltip.py", line 112, in test_showtip_on_mouse_enter_hover_delay
self.assertFalse(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable())
AssertionError: 1 is not false
|
Sorry, something went wrong.
|
@taleinat @vstinner This buildbot IDLE test failure is a false positive that coincidentally occurred when testing another, trivial, IDLE change. What this report omits is that the test passed on the retest. The test that failed is a year old, written by Tal. (ENV CHANGED is from test_multiprocessing_spawn.) Victor: Have you seen this failure before. Also, I thought the point of retest was to ignore transient failures like this? |
Sorry, something went wrong.
|
I forgot about seeing this before. See issue 35771. |
Sorry, something went wrong.
Stop depending on tkinter import *.
Stop depending on tkinter import *.
Stop depending on tkinter import *.
Stop depending on tkinter import *.
https://bugs.python.org/issue29446