bpo-37628: Fix IDLE config sample sizes#14958
Conversation
Sorry, something went wrong.
If the normal background is not white, it makes a jagged border between sample background and following white block.
|
I am reviewing and making a few edits now. |
Sorry, something went wrong.
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Thank you for the quick response. It stops the size explosion issue and with a minor tweak each, the samples look as good as they can without letting the boxes get wider (up to some limit, and at best a future issue). (In reviewing, I found a couple of other issues with the highlight sample that I want to fix tomorrow. along with the key bindings).
My main concern is the addition of two new features (the Text subclass and its decorator and associated code) that seem to me not unneeded here. Until persuaded otherwise, I would like the code simplified, but given the time situation, I am willing to try that in a separate PR.
Sorry, something went wrong.
|
@terryjreedy, I've made the changes you suggested, except for the comment about |
Sorry, something went wrong.
|
FYI, I put up a cleaned version of the generic scrollable text frame as a gist. |
Sorry, something went wrong.
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Great. I will merge when CI passes after the minor tweaks.
Sorry, something went wrong.
|
@terryjreedy: Please replace |
Sorry, something went wrong.
|
Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Sorry, something went wrong.
|
Sorry @taleinat and @terryjreedy, I had trouble checking out the |
Sorry, something went wrong.
The boxes for the font and highlight samples are now constrained by the overall config dialog size. They gain scrollbars when the when a large font size makes the samples too large for the box. (cherry picked from commit 3221a63) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
|
Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
The boxes for the font and highlight samples are now constrained by the overall config dialog size. They gain scrollbars when the when a large font size makes the samples too large for the box. (cherry picked from commit 3221a63) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
The boxes for the font and highlight samples are now constrained by the overall config dialog size. They gain scrollbars when the when a large font size makes the samples too large for the box. (cherry picked from commit 3221a63) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
The boxes for the font and highlight samples are now constrained by the overall config dialog size. They gain scrollbars when the when a large font size makes the samples too large for the box. (cherry picked from commit 3221a63) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
The boxes for the font and highlight samples are now constrained by the overall config dialog size. They gain scrollbars when the when a large font size makes the samples too large for the box.
The boxes for the font and highlight samples are now constrained by the overall config dialog size. They gain scrollbars when the when a large font size makes the samples too large for the box.
The boxes for the font and highlight samples are now constrained by the overall config dialog size. They gain scrollbars when the when a large font size makes the samples too large for the box.
This fixes the issue where setting a large font size makes the config dialog grow, in some cases making it unusable by pushing the dialog buttons (e.g. "Ok", "Cancel") off-screen.
Tested on Windows 10 and Ubuntu 18.10.
https://bugs.python.org/issue37628