{{ message }}
[3.14] gh-87451: Apply CVE-2021-4189 PASV fix to ftplib.ftpcp() (GH-149648)#149793
Merged
gpshead merged 1 commit intoMay 13, 2026
Merged
[3.14] gh-87451: Apply CVE-2021-4189 PASV fix to ftplib.ftpcp() (GH-149648)#149793gpshead merged 1 commit into
gpshead merged 1 commit into
Conversation
Contributor
Sorry, something went wrong.
…nGH-149648) ftpcp() called parse227() directly and passed the source server's self-reported PASV IPv4 address to the target server's PORT command, bypassing the CVE-2021-4189 fix that was applied only to FTP.makepasv(). A malicious source FTP server could use this to redirect the target server's data connection to an arbitrary host:port (SSRF). ftpcp() now uses the source server's actual peer address, honoring the existing trust_server_pasv_ipv4_address opt-out, the same as makepasv(). Thanks to Qi Ding at Aurascape AI for the report. (GHSA-w8c5-q2xf-gf7c) (cherry picked from commit eac4fe3) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
This was referenced May 13, 2026
Hide details
View details
gpshead
merged commit
gpshead
merged commit 7d95a1d
into
python:3.14
May 13, 2026
52 checks passed
LearningCircuit
added a commit
to LearningCircuit/local-deep-research
that referenced
this pull request
May 17, 2026
Grype alerts on CVE-2026-8328 against python:3.14.5-slim. The vulnerability is an SSRF in the undocumented ftplib.ftpcp() helper — the same PASV-trust class as CVE-2021-4189, whose original 2021 fix only patched ftplib.FTP and left ftpcp() unprotected. Upstream merged the fix to the CPython 3.14 branch on 2026-05-13 (python/cpython#149793), three days after Python 3.14.5 was tagged. No 3.14.6 release exists yet, so a base-image bump isn't an option. Not exploitable here: `grep -rn "ftplib\|ftpcp" src/` returns zero hits, and no transitive dependency imports ftplib either, so ftpcp() is unreachable from this image. Added to .grype.yaml in the existing python3.14 block alongside the other CPython CVEs awaiting the next 3.14.x point release. The suppression auto-cleans when the next Python bump picks up 3.14.6+.
2 tasks
LearningCircuit
added a commit
to LearningCircuit/local-deep-research
that referenced
this pull request
May 17, 2026
…4.6 (#4072) Grype alerts on CVE-2026-8328 against python:3.14.5-slim. The vulnerability is an SSRF in the undocumented ftplib.ftpcp() helper — the same PASV-trust class as CVE-2021-4189, whose original 2021 fix only patched ftplib.FTP and left ftpcp() unprotected. Upstream merged the fix to the CPython 3.14 branch on 2026-05-13 (python/cpython#149793), three days after Python 3.14.5 was tagged. No 3.14.6 release exists yet, so a base-image bump isn't an option. Not exploitable here: `grep -rn "ftplib\|ftpcp" src/` returns zero hits, and no transitive dependency imports ftplib either, so ftpcp() is unreachable from this image. Added to .grype.yaml in the existing python3.14 block alongside the other CPython CVEs awaiting the next 3.14.x point release. The suppression auto-cleans when the next Python bump picks up 3.14.6+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
ftpcp() called parse227() directly and passed the source server's
self-reported PASV IPv4 address to the target server's PORT command,
bypassing the CVE-2021-4189 fix that was applied only to FTP.makepasv().
A malicious source FTP server could use this to redirect the target
server's data connection to an arbitrary host:port (SSRF).
ftpcp() now uses the source server's actual peer address, honoring the
existing trust_server_pasv_ipv4_address opt-out, the same as makepasv().
Thanks to Qi Ding at Aurascape AI for the report. (GHSA-w8c5-q2xf-gf7c)
(cherry picked from commit eac4fe3)
Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com