◐ Shell
reader mode source ↗
Skip to content

bpo-30303: IDLE: Add _utest argument to textview#1499

Merged
terryjreedy merged 8 commits into
python:masterfrom
louisom:bpo-30303
May 17, 2017
Merged

bpo-30303: IDLE: Add _utest argument to textview#1499
terryjreedy merged 8 commits into
python:masterfrom
louisom:bpo-30303

Conversation

@louisom

@louisom louisom commented May 8, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@louisom louisom changed the title bpo-30303: Add _utest argument to textview May 10, 2017
terryjreedy
terryjreedy requested changes May 17, 2017
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

At first reading, the textview.py changes are just right. The test needs some minor changes.

@codecov

codecov Bot commented May 17, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1499 into master will decrease coverage by 0.75%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   83.44%   82.68%   -0.76%     
==========================================
  Files        1368     1432      +64     
  Lines      346621   353062    +6441     
==========================================
+ Hits       289241   291934    +2693     
- Misses      57380    61128    +3748
Impacted Files Coverage Δ
Lib/idlelib/idle_test/test_textview.py 3.12% <0%> (-1.43%) ⬇️
Lib/idlelib/textview.py 25.45% <57.14%> (-0.48%) ⬇️
Lib/__future__.py 6.45% <0%> (-90.33%) ⬇️
Lib/test/test_select.py 87.69% <0%> (-1.54%) ⬇️
Lib/wsgiref/handlers.py 88.41% <0%> (-0.86%) ⬇️
Lib/test/libregrtest/main.py 59.18% <0%> (-0.35%) ⬇️
Lib/_strptime.py 94.68% <0%> (-0.34%) ⬇️
Lib/bdb.py 26.84% <0%> (-0.31%) ⬇️
Lib/test/test_strptime.py 94.76% <0%> (-0.27%) ⬇️
Lib/test/test_ftplib.py 95.72% <0%> (-0.26%) ⬇️
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ace65...0c33759. Read the comment docs.

terryjreedy
terryjreedy approved these changes May 17, 2017
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I am about to push my changes back and will merge once CI allows.

@terryjreedy terryjreedy merged commit ba365da into python:master May 17, 2017
@terryjreedy terryjreedy added the label May 18, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 2, 2017
@louisom @Mariatta
[3.6] bpo-30303: IDLE: Add _utest argument to textview (pythonGH-1499) …
ba5f530 
(cherry picked from commit ba365da)
@brettcannon

brettcannon commented Jun 5, 2017

Copy link
Copy Markdown
Member

Can I ask if a CLA was eventually verified as being signed before merging this?

@brettcannon brettcannon mentioned this pull request Jun 5, 2017
Merged
@Mariatta

Mariatta commented Jun 6, 2017

Copy link
Copy Markdown
Member

@brettcannon I asked the PR author in bpo-30303 about this.
It seems that @louisom is the same person as @mlouielu, and @mlouielu has signed the CLA.

@mlouielu

mlouielu commented Jun 6, 2017

Copy link
Copy Markdown
Contributor

@louisom is my previous account, does b.p.o. support comma split (louisom, mlouielu) at the detail page?

@mlouielu

mlouielu commented Jun 6, 2017

Copy link
Copy Markdown
Contributor

@Mariatta I've add another CLA to @louisom, please help to verify this, thanks!

terryjreedy pushed a commit that referenced this pull request Jun 6, 2017
@Mariatta @terryjreedy
[3.6] bpo-30303: IDLE: Add _utest argument to textview (GH-1499) (#1916) …
e1a60d9 
(cherry picked from commit ba365da)
@brettcannon

brettcannon commented Jun 7, 2017

Copy link
Copy Markdown
Member

@Mariatta @mlouielu thanks for the clarification!

@terryjreedy terryjreedy mentioned this pull request Jun 10, 2017
Closed
@miss-islington

miss-islington commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @louisom for the PR, and @terryjreedy for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

@miss-islington

miss-islington commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

Sorry, @louisom and @terryjreedy, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.

@terryjreedy

terryjreedy commented Sep 7, 2017

Copy link
Copy Markdown
Member

The backport error is because this was backported already in #1916. (And the file has been refactored since.) I removed the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@louisom @brettcannon @Mariatta @mlouielu @miss-islington @terryjreedy @the-knights-who-say-ni