{{ message }}
gh-59999: zipfile: restore Unix permissions after extraction#150061
Open
Aniketsy wants to merge 1 commit into
Open
gh-59999: zipfile: restore Unix permissions after extraction#150061Aniketsy wants to merge 1 commit into
zipfile: restore Unix permissions after extraction#150061Aniketsy wants to merge 1 commit into
Conversation
Contributor
Sorry, something went wrong.
serhiy-storchaka
changed the title
zipfile: restore Unix permissions after extraction
Contributor
Author
|
As this pr is linked to quite old issue, i'm really excited and looking forward to fix. waiting for members to review and give suggestion for this if we need improvements. Thanks! |
Sorry, something went wrong.
Contributor
Author
|
@vstinner gentle ping, please have a look in this when you get chance . Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
fixes #149839
zip file, stored Unix permissions were ignored and files always got default permissions instead.os.chmodafter extraction.zipfile.extractallnever restores stored Unix permissions #149839