◐ Shell
reader mode source ↗
Skip to content

gh-150178: Fix refcount leaks in hamt allocation failure paths#150179

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
lpyu001:hamt
May 23, 2026
Merged

gh-150178: Fix refcount leaks in hamt allocation failure paths#150179
kumaraditya303 merged 2 commits into
python:mainfrom
lpyu001:hamt

Conversation

@lpyu001

@lpyu001 lpyu001 commented May 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@lpyu001 lpyu001 requested a review from 1st1 as a code owner May 21, 2026 08:04
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2026
Closed
@picnixz picnixz changed the title gh-150178:Fix refcount leaks in hamt allocation failure paths May 21, 2026
@aisk

aisk commented May 21, 2026

Copy link
Copy Markdown
Member

The fix looks good to me. However, I think the NEWS entry is too internal-facing, and it's a rare-case fix, so I don't think we need a NEWS entry for it.

@aisk aisk added the skip news label May 21, 2026
@lpyu001

lpyu001 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

The fix looks good to me. However, I think the NEWS entry is too internal-facing, and it's a rare-case fix, so I don't think we need a NEWS entry for it.

thanks for your comments, I've delete NEWS

Hide details View details @kumaraditya303 kumaraditya303 merged commit 32823af into python:main May 23, 2026
60 checks passed
@kumaraditya303 kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 23, 2026
@miss-islington-app

miss-islington-app Bot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented May 23, 2026

Copy link
Copy Markdown

GH-150301 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 23, 2026
kumaraditya303 pushed a commit that referenced this pull request May 23, 2026
@miss-islington @lpyu001
[3.13] gh-150178: Fix refcount leaks in hamt allocation failure paths (… …
95c9323 
…GH-150179) (#150301)

gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)

Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
kumaraditya303 pushed a commit that referenced this pull request May 23, 2026
@miss-islington @lpyu001
[3.15] gh-150178: Fix refcount leaks in hamt allocation failure paths (… …
6b17d1a 
…GH-150179) (#150303)

gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)

Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
kumaraditya303 pushed a commit that referenced this pull request May 24, 2026
@miss-islington @lpyu001
[3.14] gh-150178: Fix refcount leaks in hamt allocation failure paths (… …
5676bfc 
…GH-150179) (#150302)

gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)

Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes

@kumaraditya303 kumaraditya303

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lpyu001 @aisk @kumaraditya303