{{ message }}
gh-84649: Use statx() in TimedRotatingFileHandler if available#150968
Merged
serhiy-storchaka merged 3 commits intoJun 6, 2026
Merged
gh-84649: Use statx() in TimedRotatingFileHandler if available#150968serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
Member
Sorry, something went wrong.
serhiy-storchaka
commented
Jun 5, 2026
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
Author
There was a problem hiding this comment.
@vstinner, could you please look at this? Do I use statx() like it is supposed to be used?
Sorry, something went wrong.
This allows to support rotation based on the file birth time on Linux.
serhiy-storchaka
force-pushed
the
TimedRotatingFileHandler-statx
branch
from
e584956 to
e1c910e
Compare
June 5, 2026 13:11
vstinner
approved these changes
Jun 5, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. The code using os.statx() is correct. Don't forget to uncomment # @support.requires_resource('walltime').
Sorry, something went wrong.
Documentation build overview
|
Sorry, something went wrong.
Hide details
View details
serhiy-storchaka
merged commit
serhiy-storchaka
merged commit b18b6a4
into
python:main
Jun 6, 2026
52 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This allows to support rotation based on the file birth time on Linux.