◐ Shell
reader mode source ↗
Skip to content

bpo-37765: Add keywords to IDLE tab completions#15138

Merged
terryjreedy merged 12 commits into
python:masterfrom
terryjreedy:c_keyword
Jul 9, 2020
Merged

bpo-37765: Add keywords to IDLE tab completions#15138
terryjreedy merged 12 commits into
python:masterfrom
terryjreedy:c_keyword

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Aug 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key.

Rewrite Completions doc.

https://bugs.python.org/issue37765

@terryjreedy terryjreedy added type-feature A feature request or enhancement needs backport to 3.7 labels Aug 5, 2019
@terryjreedy terryjreedy self-assigned this Aug 5, 2019
tirkarthi
tirkarthi approved these changes Aug 6, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Thanks @terryjreedy .

csabella
csabella requested changes Jan 19, 2020
View reviewed changes

@csabella csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Make sure list has no duplicates.

@bedevere-bot

bedevere-bot commented Jan 19, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@terryjreedy terryjreedy changed the title bpo-37765: Add keywords to IDLE's main completion list Jul 7, 2020
@terryjreedy

terryjreedy commented Jul 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Cheryl, please review again, including the rewritten Completions section.
...
Tal thinks adding half is worse that adding all, so I will change back when fresher.

@csabella

csabella commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

The functionality works as designed. I agree with Tal that having some missing keywords (like pass) is a little awkward.

terryjreedy and others added 3 commits July 8, 2020 18:47
@terryjreedy @csabella
that lists …
31b2fc3 
Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@terryjreedy @csabella
Add date directive. …
f8a8cad 
Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@terryjreedy
Merge remote-tracking branch 'upstream/master' into c_keyword
b898ac0
@terryjreedy terryjreedy changed the title bpo-37765: Add longer keywords to IDLE tab completions Jul 9, 2020
15 hidden items Load more…
@terryjreedy terryjreedy removed needs backport to 3.7 type-feature A feature request or enhancement labels Jul 9, 2020
@terryjreedy terryjreedy merged commit bce2eb4 into python:master Jul 9, 2020
@miss-islington

miss-islington commented Jul 9, 2020

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
@terryjreedy @miss-islington
bpo-37765: Add keywords to IDLE tab completions (pythonGH-15138) …
ee3eae1 
Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key.

Rewrite Completions doc.

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
(cherry picked from commit bce2eb4)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot

bedevere-bot commented Jul 9, 2020

Copy link
Copy Markdown

GH-21423 is a backport of this pull request to the 3.9 branch.

@bedevere-bot

bedevere-bot commented Jul 9, 2020

Copy link
Copy Markdown

GH-21424 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
@terryjreedy @miss-islington
bpo-37765: Add keywords to IDLE tab completions (pythonGH-15138) …
2c400db 
Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key.

Rewrite Completions doc.

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
(cherry picked from commit bce2eb4)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy terryjreedy deleted the c_keyword branch July 9, 2020 22:49
miss-islington added a commit that referenced this pull request Jul 9, 2020
@miss-islington @terryjreedy
bpo-37765: Add keywords to IDLE tab completions (GH-15138) …
fd27fb7 
Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key.

Rewrite Completions doc.

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
(cherry picked from commit bce2eb4)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Jul 9, 2020
@miss-islington @terryjreedy
bpo-37765: Add keywords to IDLE tab completions (GH-15138) …
3d1c06e 
Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key.

Rewrite Completions doc.

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
(cherry picked from commit bce2eb4)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@terryjreedy @csabella @shihai1991
bpo-37765: Add keywords to IDLE tab completions (pythonGH-15138) …
4afdfeb 
Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key.

Rewrite Completions doc.

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@terryjreedy @csabella @xzy3-cdc
bpo-37765: Add keywords to IDLE tab completions (pythonGH-15138) …
138ccdd 
Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key.

Rewrite Completions doc.

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@csabella csabella csabella approved these changes

Assignees

@terryjreedy terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@terryjreedy @bedevere-bot @csabella @miss-islington @tirkarthi @the-knights-who-say-ni