◐ Shell
reader mode source ↗
Skip to content

bpo-15786: IDLE: Fix autocomletetion mouse click and freeze behavior#1517

Closed
louisom wants to merge 6 commits into
python:masterfrom
louisom:bpo-15786
Closed

bpo-15786: IDLE: Fix autocomletetion mouse click and freeze behavior#1517
louisom wants to merge 6 commits into
python:masterfrom
louisom:bpo-15786

Conversation

@louisom

@louisom louisom commented May 9, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@mention-bot

mention-bot commented May 9, 2017

Copy link
Copy Markdown

@lulouie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @Yhg1s to be potential reviewers.

@louisom
Fix MacOS double click autocomplete box will freeze …
1da0c6a 
The root cause is we destory autocompletewindow to fast,
thus tk can't focusOn widget, we should re-focus on widget
first, then destory autocompletewindow.
@louisom

louisom commented May 10, 2017

Copy link
Copy Markdown
Contributor Author

@terryjreedy This fixed the MacOS freeze and double click disappear problem, please help to take a review

@louisom louisom changed the title bpo-15786: Fix autocomletetion box mouse behavior May 10, 2017
terryjreedy
terryjreedy requested changes May 11, 2017
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Trivial formatting change.
Does not solve issue on Windows.

@louisom

louisom commented May 11, 2017

Copy link
Copy Markdown
Contributor Author

I must admire your work in IDLE, terry. Tk has bunch of cross-platform holes. On windows it can't work is because somehow winconfig will be trigger multiple time (just like a infinity loop), and let Tk can't respond to Double-ButtonRelease.

The fix will unbind winconfig_event when we are in the windows platform to prevent this problem.

@mlouielu mlouielu mentioned this pull request May 25, 2017
Merged
@louisom

louisom commented May 25, 2017

Copy link
Copy Markdown
Contributor Author

Close this issue and transfer to #1811

@louisom louisom closed this May 25, 2017
@suddhasourav suddhasourav mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@louisom @mention-bot @terryjreedy @the-knights-who-say-ni