◐ Shell
reader mode source ↗
Skip to content

bpo-36511 fix failures in Windows Python arm32 buildbot tests#15181

Merged
zooba merged 2 commits into
python:masterfrom
paulmon:fix_arm32_buildbot
Aug 8, 2019
Merged

bpo-36511 fix failures in Windows Python arm32 buildbot tests#15181
zooba merged 2 commits into
python:masterfrom
paulmon:fix_arm32_buildbot

Conversation

@paulmon

@paulmon paulmon commented Aug 8, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@zooba, @zware

win_utils.py: If an exception is thrown during WindowsLoadTracker creation, which is expected on Windows ARM32, then when WindowsLoadTracker.close( ) is called then self.p is not defined. This change ensures that self.p is always initialized.

test_compile.py: test_stack_overflow throws a MemoryException randomly on Windows arm32. I believe this test is running out of memory because the arm32 test hardware only has 1 GB of RAM. What is the best way to fix this? Is handling the MemoryException ok? or does that cover up a real problem?

remoteDeploy.bat: the files in the Parser directory are needed to prevent warnings when running test_asdl_parser.

Please let me know if I should split this into multiple PRs or create new issue(s).

Thanks,
Paul

https://bugs.python.org/issue36511

@zooba

zooba commented Aug 8, 2019

Copy link
Copy Markdown
Member

The MemoryError might be hiding something else, unless it's because of the string generation. In which case, I'd separate that out from the compile call.

@paulmon

paulmon commented Aug 8, 2019

Copy link
Copy Markdown
Contributor Author

The string generation didn't cause a MemoryError.
Undoing suppressing the exception.

@zooba zooba merged commit ed70a34 into python:master Aug 8, 2019
@miss-islington

miss-islington commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

miss-islington commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2019
@paulmon @miss-islington
bpo-36511: Fix failures in Windows ARM32 buildbot (pythonGH-15181) …
e9fb678 
(cherry picked from commit ed70a34)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Aug 8, 2019

Copy link
Copy Markdown

GH-15186 is a backport of this pull request to the 3.8 branch.

@paulmon paulmon deleted the fix_arm32_buildbot branch August 12, 2019 20:06
@vstinner vstinner mentioned this pull request Aug 14, 2019
Merged
vstinner added a commit that referenced this pull request Aug 14, 2019
@vstinner
[3.8] bpo-37531: Fix regrtest timeout for subprocesses (GH-15072) (GH… …
d85c567 
…-15279)

* bpo-37531: Fix regrtest timeout for subprocesses (GH-15072)

Co-Authored-By: Joannah Nanjekye <joannah.nanjekye@ibm.com>
(cherry picked from commit b0c8369)

* bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181)

(cherry picked from commit ed70a34)

Backport also minor fixes from master (fix typo, remove importlib import).
@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2019
@paulmon @miss-islington
bpo-36511: Fix failures in Windows ARM32 buildbot (pythonGH-15181) …
bf856c7 
(cherry picked from commit ed70a34)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Aug 29, 2019

Copy link
Copy Markdown

GH-15571 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 29, 2019
@miss-islington @paulmon
bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181) …
ed00fee 
(cherry picked from commit ed70a34)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@paulmon @lisroach
bpo-36511: Fix failures in Windows ARM32 buildbot (pythonGH-15181)
163abd8
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@paulmon @DinoV
bpo-36511: Fix failures in Windows ARM32 buildbot (pythonGH-15181)
452caa8
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@paulmon @websurfer5
bpo-36511: Fix failures in Windows ARM32 buildbot (pythonGH-15181)
d9bc7e6
@paulmon paulmon mannequin mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@paulmon @zooba @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni