{{ message }}
bpo-37812: Make the small-int alloc optimization unconditional.#15203
Closed
gnprice wants to merge 2 commits into
Closed
bpo-37812: Make the small-int alloc optimization unconditional.#15203gnprice wants to merge 2 commits into
gnprice wants to merge 2 commits into
Conversation
Contributor
Sorry, something went wrong.
This optimization was added in 1993 (commit 842d2cc), and we've been running with it ever since. I think at this point it's fair to say that it's no longer experimental. That lets us simplify the code by removing a number of `#ifdef`s. In particular this will help us simplify the usage of CHECK_SMALL_INT.
aeros
reviewed
Aug 10, 2019
aeros
left a comment
aeros
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR.
I had a minor suggestion for the news entry:
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer
Assignees
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This optimization was added in 1993 (commit 842d2cc), and we've
been running with it ever since. I think at this point it's fair
to say that it's no longer experimental. That lets us simplify
the code by removing a number of
#ifdefs.In particular this will help us simplify the usage of CHECK_SMALL_INT.
https://bugs.python.org/issue37812