◐ Shell
reader mode source ↗
Skip to content

gh-82002: IDLE completion namespace fix#15207

Open
taleinat wants to merge 2 commits into
python:mainfrom
taleinat:bpo-37821/idle-completion-namespace
Open

gh-82002: IDLE completion namespace fix#15207
taleinat wants to merge 2 commits into
python:mainfrom
taleinat:bpo-37821/idle-completion-namespace

Conversation

@taleinat

@taleinat taleinat commented Aug 11, 2019 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Contributor

@taleinat taleinat added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Aug 11, 2019
@taleinat taleinat requested a review from terryjreedy as a code owner August 11, 2019 11:21
@terryjreedy terryjreedy changed the title bpo-37821: IDLE completion namespace fix Oct 5, 2022
@terryjreedy terryjreedy mentioned this pull request Oct 5, 2022
Open
iritkatriel
iritkatriel previously requested changes Nov 27, 2022
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This has merge conflicts now.

@bedevere-bot

bedevere-bot commented Nov 27, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@terryjreedy terryjreedy dismissed iritkatriel’s stale review November 28, 2022 02:25

Merge conflicts fixed.

@terryjreedy

terryjreedy commented Nov 28, 2022

Copy link
Copy Markdown
Member

Merge conflict in autocomplete.py: __init__ parameter tags added for #25708, this adds namespace. Put latter after former because tags passed positionally in editor. Should make both or all 3 keyword-only in separate patch and fix call.

Merge conflict in run.py: changed code made conditional on not testing by #24302, which added tests for respecting excepthook.

@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel

@terryjreedy terryjreedy

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time. type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@taleinat @bedevere-bot @terryjreedy @iritkatriel @ambv @the-knights-who-say-ni @ezio-melotti