A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@matrixise: please review the changes made to this pull request.

ping

I really would like to see this landed in Python so I could apply a backport to fix https://bugs.tryton.org/issue8574

ping @matrixise

@matrixise could you review the changes you requested, thanks.

@cedk If you wouldn't mind, could you avoid force-pushing the PR branch after each commit in the future? It makes it rather difficult to follow the commit history of the PR, before and after the review feedback. We advise against doing so in the devguide:

Your pull request may involve several commits as a result of addressing code review comments. Please keep the commit history in the pull request intact by not squashing, amending, or anything that would require a force push to GitHub. A detailed commit history allows reviewers to view the diff of one commit to another so they can easily verify whether their comments have been addressed. The commits will be squashed when the pull request is merged.

@aeros sorry, I would no more do that. Indeed I'm used to mercurial for which such workflow is well supported thanks to evolve.

@matrixise could you point me to the changes you are requesting?

@cedk I am sincerely sorry if I was absent, I will look at your PR in the next two weeks.

Hi @cedk ,

As said @aeros , you don't need to force the push, just push with your commits (we can see all the commits and discuss some points), and when we merge the PR, we will use the squash and merge feature. It's pretty useful.

I continue the review of your PR.

Thank you

@cedk just one thing, could you update it with the last master? Thank you so much,

@cedk just one thing, could you update it with the last master? Thank you so much,

But there is no conflict.

Thank you so much for your PR, and I am really sorry for this very bid delay between your proposal and the merge. Thank you again for your patience. Take care