◐ Shell
reader mode source ↗
Skip to content

bpo-37942: Improve argument clinic float converter#15470

Merged
rhettinger merged 6 commits into
python:masterfrom
rhettinger:arg_clinic_float_converter
Aug 25, 2019
Merged

bpo-37942: Improve argument clinic float converter#15470
rhettinger merged 6 commits into
python:masterfrom
rhettinger:arg_clinic_float_converter

Conversation

@rhettinger

@rhettinger rhettinger commented Aug 24, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@rhettinger rhettinger added type-bug An unexpected behavior, bug, or error performance Performance or resource usage needs backport to 3.8 labels Aug 24, 2019
serhiy-storchaka
serhiy-storchaka approved these changes Aug 24, 2019
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

Do you want to add the same optimization in getargs.c?

@rhettinger
Add fast path for exact floats. …
1013850 
Baseline timing:
./python.exe -m timeit -r11 -s 'from statistics import _normal_dist_inv_cdf as f' -s 't=0.75,0.0,1.0' 'f(*t)'
5000000 loops, best of 11: 61.1 nsec per loop

Improved timing:
./python.exe -m timeit -r11 -s 'from statistics import _normal_dist_inv_cdf as f' -s 't=0.75,0.0,1.0' 'f(*t)'
5000000 loops, best of 11: 52.5 nsec per loop
@rhettinger
Apply the same fix to getargs.c
c86d12c
@rhettinger

rhettinger commented Aug 25, 2019

Copy link
Copy Markdown
Contributor Author

Serhiy, do you know how to regenerate or edit 'Lib/test/clinic.test' ?

@rhettinger rhettinger requested a review from tiran as a code owner August 25, 2019 01:32
@rhettinger rhettinger merged commit aef9ad8 into python:master Aug 25, 2019
@rhettinger rhettinger deleted the arg_clinic_float_converter branch August 25, 2019 02:10
@miss-islington

miss-islington commented Aug 25, 2019

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 25, 2019

Copy link
Copy Markdown
Contributor

Sorry, @rhettinger, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aef9ad82f7f667cd001a7112d3bc636e918626f7 3.8

rhettinger added a commit to rhettinger/cpython that referenced this pull request Aug 25, 2019
@rhettinger
[3.8] bpo-37942: Improve argument clinic float converter (pythonGH-15470 …
4ba388c 
)

(cherry picked from commit aef9ad8)
@bedevere-bot

bedevere-bot commented Aug 25, 2019

Copy link
Copy Markdown

GH-15480 is a backport of this pull request to the 3.8 branch.

rhettinger added a commit that referenced this pull request Aug 25, 2019
@rhettinger
[3.8] bpo-37942: Improve argument clinic float converter (GH-15470) (G… …
21161d7 
…H-15480)

(cherry picked from commit aef9ad8)
@serhiy-storchaka

serhiy-storchaka commented Aug 25, 2019

Copy link
Copy Markdown
Member

Serhiy, do you know how to regenerate or edit 'Lib/test/clinic.test' ?

I use the following line:

mv Lib/test/clinic.test{,.c}; ./python Tools/clinic/clinic.py --force Lib/test/clinic.test.c; mv Lib/test/clinic.test{.c,}

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@rhettinger @lisroach
bpo-37942: Improve argument clinic float converter (pythonGH-15470)
4a00657
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
bpo-37942: Improve argument clinic float converter (pythonGH-15470)
500d6be
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@rhettinger @websurfer5
bpo-37942: Improve argument clinic float converter (pythonGH-15470)
c5460fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@tiran tiran

Assignees

@rhettinger rhettinger

Labels

performance Performance or resource usage type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhettinger @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni