{{ message }}
bpo-36670: fixed encoding issue with libregrtest on win systems#15488
Closed
LorenzMende wants to merge 1 commit into
Closed
bpo-36670: fixed encoding issue with libregrtest on win systems#15488LorenzMende wants to merge 1 commit into
LorenzMende wants to merge 1 commit into
Conversation
Contributor
Sorry, something went wrong.
detailed: fixed decoding of typeperf in regrtest for win environments, added lookup for locations dependent typeperf key
zooba
reviewed
Aug 26, 2019
Member
|
If it's not too much work, could you create a PR with your alternative solution from bpo whereby you raise early and the load average calculation gets disabled. This really feels like a lot of extra complexity for not much gain, the primary reason system load averages are reported in regrtest is to track down flaky parallel/race condition/non deterministic tests. Those are primarily run on CI machines and build-bots which are almost always English machines anyway |
Sorry, something went wrong.
Member
|
I merged PR #16511 which is contains a similar fix, but also multiple other regrtest bugfixes. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
detailed: fixed decoding of typeperf in regrtest for win environments, added lookup for locations dependent typeperf key
https://bugs.python.org/issue36670