◐ Shell
reader mode source ↗
Skip to content

bpo-37947: Adjust correctly the recursion level in symtable for named expressions#15499

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo37947
Aug 26, 2019
Merged

bpo-37947: Adjust correctly the recursion level in symtable for named expressions#15499
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo37947

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal requested a review from ncoghlan August 26, 2019 14:32
@pablogsal

pablogsal commented Aug 26, 2019

Copy link
Copy Markdown
Member Author

This is a fix also part of https://bugs.python.org/issue37954.

I will merge it to fix the reference leak for unblocking the upcoming beta release.

@pablogsal pablogsal merged commit 0e4ea16 into python:master Aug 26, 2019
@pablogsal pablogsal deleted the bpo37947 branch August 26, 2019 14:52
@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0e4ea16336685cf3fa353d8c54af59b45b2d5c33 3.8

@bedevere-bot

bedevere-bot commented Aug 26, 2019

Copy link
Copy Markdown

GH-15515 is a backport of this pull request to the 3.8 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 26, 2019
@pablogsal
[3.8] bpo-37947: Adjust correctly the recursion level in symtable for… …
1d01f4e 
… named expressions (pythonGH-15499)

(cherry picked from commit 0e4ea16)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 26, 2019
@pablogsal
[3.8] bpo-37947: Adjust correctly the recursion level in symtable for… …
3769425 
… named expressions (GH-15499) (GH-15515)

(cherry picked from commit 0e4ea16)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@pablogsal @lisroach
bpo-37947: Adjust correctly the recursion level in symtable for named… …
f09c2a4 
… expressions (pythonGH-15499)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-37947: Adjust correctly the recursion level in symtable for named… …
a17ec91 
… expressions (pythonGH-15499)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@pablogsal @websurfer5
bpo-37947: Adjust correctly the recursion level in symtable for named… …
4a3e647 
… expressions (pythonGH-15499)
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan left review comments

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @ncoghlan @the-knights-who-say-ni