◐ Shell
reader mode source ↗
Skip to content

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs#15522

Merged
miss-islington merged 2 commits into
python:masterfrom
corona10:bpo-22347
Sep 5, 2019
Merged

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs#15522
miss-islington merged 2 commits into
python:masterfrom
corona10:bpo-22347

Conversation

@corona10

@corona10 corona10 commented Aug 26, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

@corona10 corona10 requested a review from a team as a code owner August 26, 2019 16:04
@corona10

corona10 commented Aug 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

@zooba @asvetlov
This issue is pretty old remained an issue. I'd like to close this issue.
Can you please take a look?

@corona10 corona10 changed the title bpo-22347: Remove urllib.parse._splittype from mimetypes.guess_type. Aug 27, 2019
@corona10

corona10 commented Aug 27, 2019

Copy link
Copy Markdown
Member Author

@epicfaace
Thanks for the review. I 've updated the PR. Please take a look

epicfaace
epicfaace approved these changes Aug 27, 2019
View reviewed changes

@epicfaace epicfaace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good!

@corona10

corona10 commented Aug 27, 2019

Copy link
Copy Markdown
Member Author

Thanks alot!

maxking
maxking suggested changes Aug 31, 2019
View reviewed changes

@maxking maxking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks @corona10 , The changes look good to me, except for the import statements (which I don't think needs any changes).

Please make sure to not force-pus after the changes and just add another additional commit. Merging the PR will squash the commits.

It is easier to lookup what changes were made after reviews through the additional commits and it gets lost if you force-push.

@bedevere-bot

bedevere-bot commented Aug 31, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10

corona10 commented Aug 31, 2019

Copy link
Copy Markdown
Member Author

@maxking
Thanks for the review, I will keep in mind not to use push force. :)
I've reverted the import.

@corona10 corona10 requested a review from maxking August 31, 2019 20:51
@corona10

corona10 commented Sep 3, 2019

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Sep 3, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@maxking: please review the changes made to this pull request.

maxking
maxking approved these changes Sep 5, 2019
View reviewed changes

@maxking maxking left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I think it looks good.

Thanks @corona10 !

8 hidden items Load more…
@miss-islington miss-islington merged commit 87bd207 into python:master Sep 5, 2019
@miss-islington

miss-islington commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2019
@corona10 @miss-islington
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs ( …
64c1f8d 
pythonGH-15522)

https://bugs.python.org/issue22347
(cherry picked from commit 87bd207)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 5, 2019

Copy link
Copy Markdown

GH-15685 is a backport of this pull request to the 3.8 branch.

@miss-islington

miss-islington commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

Sorry, @corona10, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 87bd2071c756188b6cd577889fb1682831142ceb 3.7

@miss-islington miss-islington self-assigned this Sep 5, 2019
@corona10 corona10 deleted the bpo-22347 branch September 5, 2019 00:38
@bedevere-bot

bedevere-bot commented Sep 5, 2019

Copy link
Copy Markdown

GH-15687 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 5, 2019
@miss-islington @corona10
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs ( …
6d7a786 
GH-15522)

https://bugs.python.org/issue22347
(cherry picked from commit 87bd207)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington pushed a commit that referenced this pull request Sep 5, 2019
@corona10 @miss-islington
[3.7] bpo-22347: Update mimetypes.guess_type to allow proper parsing … …
8873bff 
…of URLs (GH-15522) (GH-15687)

https://bugs.python.org/issue22347
(cherry picked from commit 87bd207)


https://bugs.python.org/issue22347



Automerge-Triggered-By: @maxking
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@corona10 @lisroach
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs ( …
3873b01 
pythonGH-15522)

https://bugs.python.org/issue22347
maxking added a commit to maxking/cpython-1 that referenced this pull request Oct 12, 2019
@maxking
bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow pr… …
78cbde4 
…oper parsing of URLs (pythonGH-15522)"

This reverts commit 87bd207.
miss-islington pushed a commit that referenced this pull request Oct 12, 2019
@maxking @miss-islington
bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow op… …
19a3d87 
…er parsing of URLs (GH-15522)" (GH-16724)

This reverts commit 87bd207.



https://bugs.python.org/issue38449
maxking added a commit that referenced this pull request Oct 12, 2019
@maxking
Revert "[3.7] bpo-22347: Update mimetypes.guess_type to allow proper … …
455869a 
…parsing of URLs (GH-15522) (GH-15687)"

This reverts commit 8873bff.
maxking added a commit to maxking/cpython-1 that referenced this pull request Oct 12, 2019
@maxking
[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to al… …
b4a84d0 
…low oper parsing of URLs (pythonGH-15522)" (pythonGH-16724)

This reverts commit 87bd207.

https://bugs.python.org/issue38449
(cherry picked from commit 19a3d87)

Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@maxking
bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow op… …
550a748 
…er parsing of URLs (pythonGH-15522)" (pythonGH-16724)

This reverts commit 87bd207.



https://bugs.python.org/issue38449
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@corona10 @DinoV
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs ( …
8afedbb 
pythonGH-15522)

https://bugs.python.org/issue22347
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@corona10 @websurfer5
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs ( …
f5047f4 
pythonGH-15522)

https://bugs.python.org/issue22347
@vadmium vadmium mentioned this pull request Apr 10, 2022
Closed
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 25, 2024
@corona10 @serhiy-storchaka
bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs ( …
0aa5b2e 
pythonGH-15522)

https://bugs.python.org/issue22347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@maxking maxking maxking approved these changes

@epicfaace epicfaace epicfaace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @bedevere-bot @miss-islington @maxking @epicfaace @the-knights-who-say-ni