bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object#1560
Conversation
|
@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brianquinlan, @asvetlov and @ezio-melotti to be potential reviewers. |
Sorry, something went wrong.
|
Thanks for caring about this issue. I think the proposed fix needs improvements, see comments. |
Sorry, something went wrong.
67e22b6 to
f24c9d4
Compare
July 3, 2017 21:32
|
Thank you for review 👍. To be honest when i was writing it i do not think about complexity at all. Please review new version. I have pushed with force, delete branch before pulling. |
Sorry, something went wrong.
f24c9d4 to
12dc30f
Compare
July 4, 2017 14:33
|
Any update on review. Please have a look at last revision. |
Sorry, something went wrong.
|
Sorry for the delay @grzgrzgrz3. The PR now has conflicts, could you please resolve them? |
Sorry, something went wrong.
reference to returned object
12dc30f to
d581bba
Compare
August 30, 2017 09:38
|
Done. |
Sorry, something went wrong.
|
I'm trying to push some small changes to your branch. Crossing fingers. |
Sorry, something went wrong.
…ying on sys.getrefcount() in tests.
ae0262c to
d67b22c
Compare
September 1, 2017 16:33
|
I'm merging this. Thank you very much! |
Sorry, something went wrong.
…not keep reference to returned object (pythonGH-1560) * bpo-27144: concurrent.futures as_complie and map iterators do not keep reference to returned object * Some nits. Improve wordings in docstrings and comments, and avoid relying on sys.getrefcount() in tests. (cherry picked from commit 97e1b1c)
* 'master' of https://github.com/python/cpython: (601 commits) remove check for bug last seem in Solaris 9 (python#3285) Change code owners for hashlib and ssl to the crypto team (python#3284) bpo-31281: Fix pathlib.Path incompatibility in fileinput (pythongh-3208) remove autoconf check for select() (python#3283) remove configure check for 'volatile' (python#3281) Add missing _sha3 module to Setup.dist (python#2395) bpo-12383: Also ignore __PYVENV_LAUNCHER__ (python#3278) bpo-9146: add the missing NEWS entry. (python#3275) Fix a c.f.as_completed() refleak previously introduced in bpo-27144 (python#3270) bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (python#3076) remove a redundant lower in urllib.parse.urlsplit (python#3008) bpo-31323: Fix reference leak in test_ssl (python#3263) bpo-31250, test_asyncio: fix EventLoopTestsMixin.tearDown() (python#3264) bpo-31326: ProcessPoolExecutor waits for the call queue thread (python#3265) bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object (python#1560) bpo-31250, test_asyncio: fix dangling threads (python#3252) bpo-31217: Fix regrtest -R for small integer (python#3260) bpo-30096: Use ABC in abc reference examples (python#1220) bpo-30737: Update DevGuide links to new URL (pythonGH-3228) [Trivial] Remove now redundant assert (python#3245) ...
…ep reference to returned object (python#1560) * bpo-27144: concurrent.futures as_complie and map iterators do not keep reference to returned object * Some nits. Improve wordings in docstrings and comments, and avoid relying on sys.getrefcount() in tests.
…ted()` This was possible before. pythonGH-1560 introduced a regression after 3.6.2 got released where only sequences were accepted now. This commit addresses this problem.
…completed()` (pythonGH-3830) This was possible before. pythonGH-1560 introduced a regression after 3.6.2 got released where only sequences were accepted now. This commit addresses this problem. (cherry picked from commit 574562c)
…completed()` (pythonGH-3830) (python#3831) This was possible before. pythonGH-1560 introduced a regression after 3.6.2 got released where only sequences were accepted now. This commit addresses this problem. (cherry picked from commit 574562c)
https://bugs.python.org/issue27144