◐ Shell
reader mode source ↗
Skip to content

bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object#1560

Merged
pitrou merged 2 commits into
python:masterfrom
grzgrzgrz3:fix-issue-27144
Sep 1, 2017
Merged

bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object#1560
pitrou merged 2 commits into
python:masterfrom
grzgrzgrz3:fix-issue-27144

Conversation

@grzgrzgrz3

@grzgrzgrz3 grzgrzgrz3 commented May 12, 2017

Copy link
Copy Markdown
Contributor

@mention-bot

Copy link
Copy Markdown

@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brianquinlan, @asvetlov and @ezio-melotti to be potential reviewers.

@pitrou pitrou changed the title bpo-27144: concurrent.futures as_complie and map iterators do not keep Jul 3, 2017
@pitrou pitrou changed the title bpo-27144: concurrent.futures as_complete and map iterators do not keep Jul 3, 2017
@pitrou

pitrou commented Jul 3, 2017

Copy link
Copy Markdown
Member

Thanks for caring about this issue. I think the proposed fix needs improvements, see comments.

@grzgrzgrz3

Copy link
Copy Markdown
Contributor Author

Thank you for review 👍. To be honest when i was writing it i do not think about complexity at all.

Please review new version. I have pushed with force, delete branch before pulling.

@grzgrzgrz3

Copy link
Copy Markdown
Contributor Author

Any update on review. Please have a look at last revision.

@pitrou

pitrou commented Aug 29, 2017

Copy link
Copy Markdown
Member

Sorry for the delay @grzgrzgrz3. The PR now has conflicts, could you please resolve them?
You'll also need to add a NEWS entry using the blurb CLI tool.

@grzgrzgrz3

Copy link
Copy Markdown
Contributor Author

Done.

@pitrou

pitrou commented Sep 1, 2017

Copy link
Copy Markdown
Member

I'm trying to push some small changes to your branch. Crossing fingers.

@pitrou

pitrou commented Sep 1, 2017

Copy link
Copy Markdown
Member

I'm merging this. Thank you very much!

@pitrou pitrou merged commit 97e1b1c into python:master Sep 1, 2017
pitrou pushed a commit to pitrou/cpython that referenced this pull request Sep 1, 2017
…not keep reference to returned object (pythonGH-1560)

* bpo-27144: concurrent.futures as_complie and map iterators do not keep
reference to returned object

* Some nits.  Improve wordings in docstrings and comments, and avoid relying on
sys.getrefcount() in tests.
(cherry picked from commit 97e1b1c)
pitrou added a commit that referenced this pull request Sep 1, 2017
…not keep reference to returned object (GH-1560) (#3266)

bpo-27144: concurrent.futures as_complie and map iterators do not keep
reference to returned object

(cherry picked from commit 97e1b1c)
34 hidden items Load more…
jimmylai pushed a commit to jimmylai/cpython that referenced this pull request Sep 4, 2017
* 'master' of https://github.com/python/cpython: (601 commits)
  remove check for bug last seem in Solaris 9 (python#3285)
  Change code owners for hashlib and ssl to the crypto team (python#3284)
  bpo-31281: Fix pathlib.Path incompatibility in fileinput (pythongh-3208)
  remove autoconf check for select() (python#3283)
  remove configure check for 'volatile' (python#3281)
  Add missing _sha3 module to Setup.dist (python#2395)
  bpo-12383: Also ignore __PYVENV_LAUNCHER__ (python#3278)
  bpo-9146: add the missing NEWS entry. (python#3275)
  Fix a c.f.as_completed() refleak previously introduced in bpo-27144 (python#3270)
  bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (python#3076)
  remove a redundant lower in urllib.parse.urlsplit (python#3008)
  bpo-31323: Fix reference leak in test_ssl (python#3263)
  bpo-31250, test_asyncio: fix EventLoopTestsMixin.tearDown() (python#3264)
  bpo-31326: ProcessPoolExecutor waits for the call queue thread (python#3265)
  bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object (python#1560)
  bpo-31250, test_asyncio: fix dangling threads (python#3252)
  bpo-31217: Fix regrtest -R for small integer (python#3260)
  bpo-30096: Use ABC in abc reference examples (python#1220)
  bpo-30737: Update DevGuide links to new URL (pythonGH-3228)
  [Trivial] Remove now redundant assert (python#3245)
  ...
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
…ep reference to returned object (python#1560)

* bpo-27144: concurrent.futures as_complie and map iterators do not keep
reference to returned object

* Some nits.  Improve wordings in docstrings and comments, and avoid relying on
sys.getrefcount() in tests.
ambv pushed a commit to ambv/cpython that referenced this pull request Sep 29, 2017
…ted()`

This was possible before.  pythonGH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2017
…completed()` (pythonGH-3830)

This was possible before.  pythonGH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
(cherry picked from commit 574562c)
ambv added a commit that referenced this pull request Sep 29, 2017
…ted()` (#3830)

This was possible before.  GH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
ambv pushed a commit that referenced this pull request Sep 29, 2017
…completed()` (GH-3830) (#3831)

This was possible before.  GH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
(cherry picked from commit 574562c)
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 3, 2017
…completed()` (pythonGH-3830) (python#3831)

This was possible before.  pythonGH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now.  This commit addresses this
problem.
(cherry picked from commit 574562c)
dalcinl added a commit to dalcinl/pythonfutures that referenced this pull request Oct 3, 2017
agronholm pushed a commit to agronholm/pythonfutures that referenced this pull request Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants