◐ Shell
reader mode source ↗
Skip to content

bpo-37834: Prevent shutil.rmtree exception#15602

Merged
ambv merged 1 commit into
python:masterfrom
ned-deily:bpo-37834-rmtree
Aug 29, 2019
Merged

bpo-37834: Prevent shutil.rmtree exception#15602
ambv merged 1 commit into
python:masterfrom
ned-deily:bpo-37834-rmtree

Conversation

@ned-deily

@ned-deily ned-deily commented Aug 29, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

when built on non-Windows system without fd system call support,
like older versions of macOS.

https://bugs.python.org/issue37834

@ned-deily
bpo-37834: Prevent shutil.rmtree exception …
b945f5a 
when built on non-Windows system without fd system call support,
like older versions of macOS.
@ned-deily ned-deily requested review from ambv and zooba August 29, 2019 20:46
@ambv

ambv commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Looks fine. Tests pass, manually tested on Windows, too.

@ambv ambv merged commit 7fcc208 into python:master Aug 29, 2019
@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Thanks @ned-deily for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Thanks @ned-deily for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Sorry @ned-deily and @ambv, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7fcc2088a50a4ecb80e5644cd195bee209c9f979 3.8

ambv pushed a commit to ambv/cpython that referenced this pull request Aug 29, 2019
@ned-deily @ambv
[3.8] bpo-37834: Prevent shutil.rmtree exception (pythonGH-15602) …
0f23929 
when built on non-Windows system without fd system call support,
like older versions of macOS.
(cherry picked from commit 7fcc208)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot

bedevere-bot commented Aug 29, 2019

Copy link
Copy Markdown

GH-15603 is a backport of this pull request to the 3.8 branch.

ambv added a commit that referenced this pull request Aug 29, 2019
@ambv @ned-deily
[3.8] bpo-37834: Prevent shutil.rmtree exception (GH-15602) (#15603) …
25a044e 
when built on non-Windows system without fd system call support,
like older versions of macOS.
(cherry picked from commit 7fcc208)

Co-authored-by: Ned Deily <nad@python.org>
@ned-deily ned-deily deleted the bpo-37834-rmtree branch September 1, 2019 17:54
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@ned-deily @lisroach
bpo-37834: Prevent shutil.rmtree exception (pythonGH-15602) …
f61fb0e 
when built on non-Windows system without fd system call support,
like older versions of macOS.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ned-deily @DinoV
bpo-37834: Prevent shutil.rmtree exception (pythonGH-15602) …
f9e842e 
when built on non-Windows system without fd system call support,
like older versions of macOS.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@ned-deily @websurfer5
bpo-37834: Prevent shutil.rmtree exception (pythonGH-15602) …
8dc8592 
when built on non-Windows system without fd system call support,
like older versions of macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv

@zooba zooba Awaiting requested review from zooba

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ned-deily @ambv @miss-islington @bedevere-bot @the-knights-who-say-ni