◐ Shell
reader mode source ↗
Skip to content

bpo-38008: Move builtin protocol whitelist to mapping instead of list#15647

Merged
ilevkivskyi merged 3 commits into
python:masterfrom
jivid:fix-issue-38008
Sep 12, 2019
Merged

bpo-38008: Move builtin protocol whitelist to mapping instead of list#15647
ilevkivskyi merged 3 commits into
python:masterfrom
jivid:fix-issue-38008

Conversation

@jivid

@jivid jivid commented Sep 2, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Sep 2, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

corona10
corona10 reviewed Sep 2, 2019
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please add news entries by using blurb tool.

https://devguide.python.org/committing/#what-s-new-and-news-entries

ilevkivskyi
ilevkivskyi reviewed Sep 2, 2019
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for PR!

I have just one suggestion, could you please add some tests? (and a news entry as @corona10 suggested)

ilevkivskyi
ilevkivskyi approved these changes Sep 12, 2019
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks, LGTM!

(Also there is a tool called blurb, so that you don't need to create the news items manually.)

@jivid

jivid commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @ilevkivskyi, didn't know about that!

@ilevkivskyi ilevkivskyi merged commit 692a0dc into python:master Sep 12, 2019
@miss-islington

miss-islington commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

Thanks @jivid for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
@jivid @miss-islington
bpo-38008: Move builtin protocol whitelist to mapping instead of list (… …
401bc57 
…pythonGH-15647)

Fixes https://bugs.python.org/issue38008
(cherry picked from commit 692a0dc)

Co-authored-by: Divij Rajkumar <drajkuma1@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 12, 2019

Copy link
Copy Markdown

GH-16021 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @jivid
bpo-38008: Move builtin protocol whitelist to mapping instead of list (… …
52baf90 
…GH-15647)

Fixes https://bugs.python.org/issue38008
(cherry picked from commit 692a0dc)

Co-authored-by: Divij Rajkumar <drajkuma1@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@jivid @DinoV
bpo-38008: Move builtin protocol whitelist to mapping instead of list (… …
2acd757 
…pythonGH-15647)

Fixes https://bugs.python.org/issue38008
YouJiacheng added a commit to YouJiacheng/typing_extensions that referenced this pull request Mar 28, 2023
@YouJiacheng
Move builtin protocol whitelist to mapping instead of list …
5716455 
and rename _PROTO_WHITELIST to _PROTO_ALLOWLIST

taken from python/cpython#15647 and python/cpython#21825
YouJiacheng added a commit to YouJiacheng/typing_extensions that referenced this pull request Mar 28, 2023
@YouJiacheng
Add test …
b7f0aba 
taken from python/cpython#15647 and python/cpython#21823
@YouJiacheng YouJiacheng mentioned this pull request Mar 28, 2023
Merged
This was referenced Nov 11, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jivid @the-knights-who-say-ni @miss-islington @bedevere-bot @corona10 @ilevkivskyi