◐ Shell
reader mode source ↗
Skip to content

bpo-28624: Add test for subprocess to check that cmd arg supports PathLike#157

Merged
berkerpeksag merged 3 commits into
python:masterfrom
sayanchowdhury:bpo28624
Feb 26, 2017
Merged

bpo-28624: Add test for subprocess to check that cmd arg supports PathLike#157
berkerpeksag merged 3 commits into
python:masterfrom
sayanchowdhury:bpo28624

Conversation

@sayanchowdhury

@sayanchowdhury sayanchowdhury commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@the-knights-who-say-ni

the-knights-who-say-ni commented Feb 18, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement tests Tests in the Lib/test dir and removed type-feature A feature request or enhancement labels Feb 18, 2017
@sayanchowdhury sayanchowdhury force-pushed the bpo28624 branch 3 times, most recently from 271a1ad to 1cb8660 Compare February 19, 2017 05:53
@sayanchowdhury

sayanchowdhury commented Feb 19, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I have updated the PR.

@ncoghlan

ncoghlan commented Feb 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

make patchcheck should clean up the trailing whitespace errors being picked up by Travis.

(Oops, after chatting to @sayanchowdhury, I realised this suggestion wasn't as useful as I thought - make patchcheck only checks uncommitted changes, so it will only help here if you first soft-reset the git state to an earlier commit)

@sayanchowdhury

sayanchowdhury commented Feb 20, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I ran make patchcheck which removed the trailing spaces. Travis also seems to be happy now.

berkerpeksag
berkerpeksag requested changes Feb 22, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I was going to merge this, but just noticed a small typo. I think this also deserves a Misc/NEWS entry since we are aim to support path-like objects in the stdlib in Python 3.6.

@sayanchowdhury

sayanchowdhury commented Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

Should add to section What's New in Python 3.6.1 release candidate 1 under Library in Misc/NEWS?

@berkerpeksag

berkerpeksag commented Feb 26, 2017

Copy link
Copy Markdown
Member

Can we please keep this PR specific to os.PathLike support? Passing cwd=b"something" is out of scope for this issue and it should be discussed on bugs.python.org.

@sayanchowdhury
bpo-28624: Add test for Popen to check that cmd arg supports PathLike …
3370e0b 
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
@sayanchowdhury

sayanchowdhury commented Feb 26, 2017

Copy link
Copy Markdown
Contributor Author

Okay, I'll then go ahead and keep the changes os.PathLike specific.

@sayanchowdhury

sayanchowdhury commented Feb 26, 2017

Copy link
Copy Markdown
Contributor Author

I have updated the code.

@berkerpeksag berkerpeksag merged commit d5c11f7 into python:master Feb 26, 2017
berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Feb 26, 2017
@sayanchowdhury @berkerpeksag
bpo-28624: Add a test that checks that cwd parameter of Popen() accep… …
a3e870d 
…ts PathLike objects (python#157)

(cherry picked from commit d5c11f7)
@berkerpeksag

berkerpeksag commented Feb 26, 2017

Copy link
Copy Markdown
Member

Thanks!

berkerpeksag added a commit that referenced this pull request Feb 26, 2017
@berkerpeksag
bpo-28624: Add a test that checks that cwd parameter of Popen() accep… …
6b81003 
…ts PathLike objects (#157) (#323)

(cherry picked from commit d5c11f7)
benjaminp added a commit that referenced this pull request Mar 2, 2017
@benjaminp
allow path-like objects to be cwd on windows …
e431c29 
#157 added the test, but it's currently (correctly) broken on windows.
@benjaminp benjaminp mentioned this pull request Mar 2, 2017
Merged
benjaminp added a commit that referenced this pull request Mar 2, 2017
@benjaminp
allow path-like objects to be cwd on windows (#389) …
f522792 
#157 added the test, but it's currently (correctly) broken on windows.
@ncoghlan

ncoghlan commented May 28, 2017

Copy link
Copy Markdown
Contributor

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

akruis added a commit to akruis/cpython that referenced this pull request Jun 20, 2018
@akruis
Stackless issue python#157: a trivial indentation fix …
d119676 
Detected by gcc -Wmisleading-indentation.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Print rate limit remaining (#157)
1138fd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@ncoghlan ncoghlan ncoghlan left review comments

@zhangyangyu zhangyangyu zhangyangyu left review comments

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

sprint tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sayanchowdhury @the-knights-who-say-ni @ncoghlan @berkerpeksag @JelleZijlstra @zhangyangyu @serhiy-storchaka