{{ message }}
bpo-37383: Updates docs to reflect AsyncMock call_count after await.#15761
Merged
lisroach merged 4 commits intoSep 9, 2019
Merged
bpo-37383: Updates docs to reflect AsyncMock call_count after await.#15761lisroach merged 4 commits into
lisroach merged 4 commits into
Conversation
Contributor
Sorry, something went wrong.
lisroach
changed the title
lisroach
changed the title
asvetlov
approved these changes
Sep 9, 2019
tirkarthi
reviewed
Sep 9, 2019
tirkarthi
reviewed
Sep 9, 2019
tirkarthi
approved these changes
Sep 9, 2019
tirkarthi
left a comment
tirkarthi
left a comment
Member
There was a problem hiding this comment.
LGTM given that we also had a discussion on this behavior.
Sorry, something went wrong.
|
@lisroach: Please replace |
Sorry, something went wrong.
Member
|
Lisa, please backport the changes to 3.8 too. Thanks. |
Sorry, something went wrong.
Contributor
|
Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2019
…ythonGH-15761) * bpo-351428: Updates documentation to reflect AsyncMock call_count after await. * Adds skip and fixes warning. * Removes extra >>>. * Adds ... in front of await mock(). (cherry picked from commit b9f65f0) Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 10, 2019
…H-15761) * bpo-351428: Updates documentation to reflect AsyncMock call_count after await. * Adds skip and fixes warning. * Removes extra >>>. * Adds ... in front of await mock(). (cherry picked from commit b9f65f0) Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…ython#15761) * bpo-351428: Updates documentation to reflect AsyncMock call_count after await. * Adds skip and fixes warning. * Removes extra >>>. * Adds ... in front of await mock().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Updates documentation to make it more clear that call_count is not updated unless the AsyncMock has been awaited.
https://bugs.python.org/issue37383