{{ message }}
[3.8] bpo-38006: Avoid closure in weakref.WeakValueDictionary (GH-15641)#15787
Merged
miss-islington merged 1 commit intoSep 9, 2019
Merged
Conversation
Contributor
Sorry, something went wrong.
weakref.WeakValueDictionary defines a local remove() function used as callback for weak references. This function was created with a closure. Modify the implementation to avoid the closure. (cherry picked from commit a2af05a) Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner
approved these changes
Sep 9, 2019
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM, good bot.
Sorry, something went wrong.
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure. Modify the implementation to avoid the closure.
(cherry picked from commit a2af05a)
Co-authored-by: Victor Stinner vstinner@redhat.com
https://bugs.python.org/issue38006