◐ Shell
reader mode source ↗
Skip to content

Remove macOS tests from Travis.#15809

Merged
benjaminp merged 1 commit into
masterfrom
travis-macOS
Sep 10, 2019
Merged

Remove macOS tests from Travis.#15809
benjaminp merged 1 commit into
masterfrom
travis-macOS

Conversation

@benjaminp

@benjaminp benjaminp commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Azure runs macOS, so we don't need Travis to do it.

@benjaminp
Remove macOS tests from Travis. …
cc5687d 
Azure runs macOS, so we don't need Travis to do it.
@benjaminp benjaminp requested a review from ned-deily September 9, 2019 16:57
@ammaraskar

ammaraskar commented Sep 9, 2019

Copy link
Copy Markdown
Member

Is overlap the only motivation for removal here? I don't think overlap is necessarily bad, after all we run Linux on both Travis and Azure as well. Windows is run on Azure and AppVeyor. The redundancy helps to figure out flaky tests/race conditions and provides some actionable information in case a particular provider goes down.

@benjaminp

benjaminp commented Sep 9, 2019 via email

Copy link
Copy Markdown
Contributor Author

@zooba

zooba commented Sep 10, 2019

Copy link
Copy Markdown
Member

I agree with this particular one, since the Travis resources are limited.

I'd prefer to keep as many parallel builds as we can though, especially cross-CI system, as that gives us better representation of different user environments.

@benjaminp benjaminp merged commit e45b217 into master Sep 10, 2019
@benjaminp benjaminp deleted the travis-macOS branch September 10, 2019 10:28
@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15831 is a backport of this pull request to the 3.8 branch.

ned-deily
ned-deily reviewed Sep 10, 2019
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I think that running the tests under macOS on Travis has not proved to be very effective at finding real problems so I support making this change. Thanks!

miss-islington added a commit that referenced this pull request Sep 10, 2019
@miss-islington @benjaminp
Remove macOS tests from Travis. (GH-15809) …
7d41e40 
Azure runs macOS, so we don't need Travis to do it.
(cherry picked from commit e45b217)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@benjaminp @ammaraskar @zooba @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni