◐ Shell
reader mode source ↗
Skip to content

Fix typo in dictobject comment#15814

Merged
DinoV merged 1 commit into
python:masterfrom
dalgarno:fix-typo-in-dictobject
Sep 10, 2019
Merged

Fix typo in dictobject comment#15814
DinoV merged 1 commit into
python:masterfrom
dalgarno:fix-typo-in-dictobject

Conversation

@dalgarno

@dalgarno dalgarno commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Fixes a small typo in the dictobject comment. Nobpo as it's a trivial fix.

@dalgarno dalgarno requested a review from methane as a code owner September 9, 2019 20:33
@aeros aeros added the docs Documentation in the Doc dir label Sep 10, 2019
aeros
aeros approved these changes Sep 10, 2019
View reviewed changes

@aeros aeros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for the PR @dalgarno and welcome!

LGTM, we just need to wait for a core developer to review this.

Since this is involving a code comment change, I'll classify this as a documentation PR.

@DinoV DinoV merged commit 359143c into python:master Sep 10, 2019
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

@DinoV: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @dalgarno for the PR, and @DinoV for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15828 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15829 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@dalgarno @miss-islington
Fix typo in dict object comment (pythonGH-15814) …
bdd9b44 
(cherry picked from commit 359143c)

Co-authored-by: dalgarno <32097481+dalgarno@users.noreply.github.com>
@methane

methane commented Sep 10, 2019

Copy link
Copy Markdown
Member

Oh, I just created a thread for this PR...

https://discuss.python.org/t/fixing-simple-typo-in-comment-not-document/2297

miss-islington added a commit that referenced this pull request Sep 10, 2019
@miss-islington @dalgarno
Fix typo in dict object comment (GH-15814) …
18fa272 
(cherry picked from commit 359143c)

Co-authored-by: dalgarno <32097481+dalgarno@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Sep 10, 2019
@miss-islington @dalgarno
Fix typo in dict object comment (GH-15814) …
9cbf43a 
(cherry picked from commit 359143c)

Co-authored-by: dalgarno <32097481+dalgarno@users.noreply.github.com>
@aeros

aeros commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

@methane:

Oh, I just created a thread for this PR...

Hmm, I can understand the concern about the messy commit logs, but I would strongly disagree that we should not accept these types of PRs. I don't think we should explicitly encourage them, but code comment typo fixing PRs provide a great introduction into the CPython workflow for new contributors. Many first time contributors start out with typo fixes, and then move on to making more impactful changes once they become more familiar with the workflow.

Also, if you want to go through the git log without seeing the typo fixes, you can simply use:

git log --grep="typo" --invert-grep

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@dalgarno @websurfer5
Fix typo in dict object comment (python#15814)
ea7cdee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV DinoV approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

@methane methane Awaiting requested review from methane

+1 more reviewer

@aeros aeros aeros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dalgarno @bedevere-bot @miss-islington @methane @aeros @DinoV @brandtbucher @benjaminp @the-knights-who-say-ni