◐ Shell
reader mode source ↗
Skip to content

bpo-38089: Move Azure Pipelines to latest VM versions and make macOS tests optional#15851

Merged
zware merged 2 commits into
python:masterfrom
zooba:bpo-38089
Sep 10, 2019
Merged

bpo-38089: Move Azure Pipelines to latest VM versions and make macOS tests optional#15851
zware merged 2 commits into
python:masterfrom
zooba:bpo-38089

Conversation

@zooba

@zooba zooba commented Sep 10, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@zooba

zooba commented Sep 10, 2019

Copy link
Copy Markdown
Member Author

Note that this will fail until #15850 and #15849 are merged.

@zooba zooba closed this Sep 10, 2019
@zooba zooba reopened this Sep 10, 2019
@zware

zware commented Sep 10, 2019

Copy link
Copy Markdown
Member

I'm a bit concerned about this one; this leaves us open to being broken by any image update. With Azure being required, that means any update that breaks us forces us to manually intervene in any PR opened before the breakage is fixed. We've had a few instances of that otherwise; I didn't like them :)

@zooba

zooba commented Sep 10, 2019

Copy link
Copy Markdown
Member Author

I guess given I found two other bugs by doing this, I can't really argue with the possibility :)

I'll see if I can figure out the current names of the images and use them explicitly.

@zooba

zooba commented Sep 10, 2019

Copy link
Copy Markdown
Member Author

@zware Waiting on your approval

zware
zware approved these changes Sep 10, 2019
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@zware zware merged commit 801f925 into python:master Sep 10, 2019
@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@zooba @miss-islington
bpo-38089: Move Azure Pipelines to latest VM versions and make macOS … …
67cd543 
…tests optional (pythonGH-15851)

(cherry picked from commit 801f925)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15879 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@zooba @miss-islington
bpo-38089: Move Azure Pipelines to latest VM versions and make macOS … …
396e3a7 
…tests optional (pythonGH-15851)

(cherry picked from commit 801f925)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15880 is a backport of this pull request to the 3.7 branch.

@zooba zooba deleted the bpo-38089 branch September 10, 2019 15:56
zooba added a commit to zooba/cpython that referenced this pull request Sep 10, 2019
@zooba
bpo-38089: Move Azure Pipelines to latest VM versions and make macOS … …
7ef4b7a 
…tests optional (pythonGH-15851)
zooba added a commit that referenced this pull request Sep 10, 2019
@miss-islington @zooba
bpo-38089: Move Azure Pipelines to latest VM versions and make macOS … …
cdce233 
…tests optional (GH-15851)

(cherry picked from commit 801f925)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Sep 10, 2019
@zooba
bpo-38089: Move Azure Pipelines to latest VM versions and make macOS … …
6a494e7 
…tests optional (GH-15851)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@zooba @websurfer5
bpo-38089: Move Azure Pipelines to latest VM versions and make macOS … …
2fd9220 
…tests optional (pythonGH-15851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

@zware zware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @zware @miss-islington @bedevere-bot @the-knights-who-say-ni