◐ Shell
reader mode source ↗
Skip to content

bpo-32592: Set Windows 8 as the minimum required version for API support#15951

Merged
zware merged 3 commits into
python:masterfrom
zooba:bpo-32592
Sep 11, 2019
Merged

bpo-32592: Set Windows 8 as the minimum required version for API support#15951
zware merged 3 commits into
python:masterfrom
zooba:bpo-32592

Conversation

@zooba

@zooba zooba commented Sep 11, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@zooba zooba requested a review from a team as a code owner September 11, 2019 13:52
@zware

zware commented Sep 11, 2019

Copy link
Copy Markdown
Member

This is going to require a change to the buildbot config to turn off the 3.x builder on the Windows 7 bot(s). I'd rather wait on this until that change is in than to have to make the change to fix the breakage.

@zooba

zooba commented Sep 11, 2019

Copy link
Copy Markdown
Member Author

It shouldn't, as the minimum API isn't actually enforced anywhere except at compile time, and all the Win10 SDKs have the Win8 APIs available.

@zware

zware commented Sep 11, 2019

Copy link
Copy Markdown
Member

I've started a buildbot-custom build to check that.

@zooba

zooba commented Sep 11, 2019

Copy link
Copy Markdown
Member Author

Don't merge this before #15949 or it'll break the other one. (That PR is being backported, and then I'll have to rebase this one...)

@zware

zware commented Sep 11, 2019

Copy link
Copy Markdown
Member

The Win7 SP1 buildbot is happy, so I'll merge this after #15949.

@zware zware merged commit 0b72ccf into python:master Sep 11, 2019
@zooba zooba deleted the bpo-32592 branch September 11, 2019 17:48
@vstinner

vstinner commented Sep 11, 2019

Copy link
Copy Markdown
Member

Thanks!

DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@zooba @DinoV
bpo-32592: Set Windows 8 as the minimum required version for API supp… …
84622f9 
…ort (pythonGH-15951)
kuba2k2 pushed a commit to kuba2k2/cpython that referenced this pull request Nov 13, 2021
@zooba @kuba2k2
Revert "bpo-32592: Set Windows 8 as the minimum required version for … …
a314395 
…API support (pythonGH-15951)"

This reverts commit 0b72ccf.
kuba2k2 pushed a commit to kuba2k2/cpython that referenced this pull request Nov 13, 2021
@zooba @kuba2k2
Revert "bpo-32592: Set Windows 8 as the minimum required version for … …
03813a6 
…API support (pythonGH-15951)"

This reverts commit 0b72ccf.
ChronoMonochrome added a commit to ChronoMonochrome/cpython that referenced this pull request Nov 16, 2021
@ChronoMonochrome
Revert "bpo-32592: Set Windows 8 as the minimum required version for … …
647c25d 
…API support (pythonGH-15951)"

This reverts commit 0b72ccf.
@vstinner vstinner mentioned this pull request May 10, 2022
Closed
kuba2k2 pushed a commit to kuba2k2/cpython that referenced this pull request Dec 5, 2024
@zooba @kuba2k2
Revert "bpo-32592: Set Windows 8 as the minimum required version for … …
9d6af12 
…API support (pythonGH-15951)"

This reverts commit 0b72ccf.
kuba2k2 pushed a commit to kuba2k2/cpython that referenced this pull request Dec 5, 2024
@zooba @kuba2k2
Revert "bpo-32592: Set Windows 8 as the minimum required version for … …
b157ccb 
…API support (pythonGH-15951)"

This reverts commit 0b72ccf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

No one assigned

Labels

OS-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @zware @vstinner @the-knights-who-say-ni @bedevere-bot