◐ Shell
reader mode source ↗
Skip to content

bpo-38136: Updates await_count and call_count to be different things#16192

Merged
lisroach merged 8 commits into
python:masterfrom
lisroach:fix_call_count
Sep 24, 2019
Merged

bpo-38136: Updates await_count and call_count to be different things#16192
lisroach merged 8 commits into
python:masterfrom
lisroach:fix_call_count

Conversation

@lisroach

@lisroach lisroach commented Sep 16, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

After a lot of discussion we have decided that "calls" and "awaits" should be counted as two different things.

To accomplish this I separated the call counting from the actual execution of the call, that way they are counted at two different times. For synchronous calls the increment and execute calls happen one immediately after another, but for asynchronous calls the increment count for call count happens first, and then only after await is called does the call execute and increment the await counters.

https://bugs.python.org/issue38136

@tirkarthi

tirkarthi commented Sep 16, 2019

Copy link
Copy Markdown
Member

Does this mean we have to revert the doc updated added in #15761 ?

@lisroach

lisroach commented Sep 16, 2019

Copy link
Copy Markdown
Contributor Author

@tirkarthi yes, I can actually just remove that doc change with this PR.

ezio-melotti
ezio-melotti requested changes Sep 17, 2019
View reviewed changes
6 hidden conversations Load more…
@bedevere-bot

bedevere-bot commented Sep 17, 2019

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@lisroach lisroach merged commit ef04851 into python:master Sep 24, 2019
@lisroach lisroach deleted the fix_call_count branch September 24, 2019 03:49
@miss-islington

miss-islington commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Sorry, @lisroach, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ef048517755db1f0d211fb6dfc655a8b412cc96f 3.8

@bedevere-bot

bedevere-bot commented Sep 26, 2019

Copy link
Copy Markdown

GH-16431 is a backport of this pull request to the 3.8 branch.

lisroach added a commit that referenced this pull request Sep 27, 2019
@lisroach
[3.8] bpo-38136: Updates await_count and call_count to be different t… …
52bdd41 
…hings (GH-16192) (GH-16431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise left review comments

@tirkarthi tirkarthi tirkarthi left review comments

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@voidspace voidspace Awaiting requested review from voidspace

Assignees

@lisroach lisroach

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lisroach @tirkarthi @bedevere-bot @miss-islington @matrixise @ezio-melotti @the-knights-who-say-ni