◐ Shell
reader mode source ↗
Skip to content

bpo-38206: Clarify tp_dealloc requirements for heap allocated types.#16248

Merged
miss-islington merged 2 commits into
python:masterfrom
ammaraskar:decref_heap
Sep 27, 2019
Merged

bpo-38206: Clarify tp_dealloc requirements for heap allocated types.#16248
miss-islington merged 2 commits into
python:masterfrom
ammaraskar:decref_heap

Conversation

@ammaraskar

@ammaraskar ammaraskar commented Sep 18, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

As mentioned in the bpo ticket, this mistake came up on two reviews:

Would be nice to have it documented in a more permanent place than 3.8's whatsnew entry.

https://bugs.python.org/issue38206

Automerge-Triggered-By: @encukou

@ammaraskar

ammaraskar commented Sep 18, 2019

Copy link
Copy Markdown
Member Author

cc @eduardo-elizondo

Happy to take any suggestions on the wording.

@ammaraskar ammaraskar added the label Sep 18, 2019
@eduardo-elizondo

eduardo-elizondo commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

Yup! Looks mostly good, just a couple of comments.

@eduardo-elizondo

eduardo-elizondo commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

One last comment. This looks good now! Ping @DinoV , could you help getting this merged?

eduardo-elizondo
eduardo-elizondo approved these changes Sep 27, 2019
View reviewed changes

@eduardo-elizondo eduardo-elizondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@miss-islington miss-islington merged commit 5faff97 into python:master Sep 27, 2019
@miss-islington

miss-islington commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

Thanks @ammaraskar for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 27, 2019

Copy link
Copy Markdown

GH-16436 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 27, 2019
@miss-islington @ammaraskar
bpo-38206: Clarify tp_dealloc requirements for heap allocated types. (G… …
14ddca7 
…H-16248)

As mentioned in the bpo ticket, this mistake came up on two reviews:
- https://github.com/python/cpython/pull/16127GH-pullrequestreview-288312751
- https://github.com/python/cpython/pull/16071GH-pullrequestreview-287819525

Would be nice to have it documented in a more permanent place than 3.8's whatsnew entry.

https://bugs.python.org/issue38206

Automerge-Triggered-By: @encukou
(cherry picked from commit 5faff97)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@ammaraskar
bpo-38206: Clarify tp_dealloc requirements for heap allocated types. (p… …
77330ed 
…ythonGH-16248)

As mentioned in the bpo ticket, this mistake came up on two reviews:
- python#16127 (review)
- python#16071 (review)

Would be nice to have it documented in a more permanent place than 3.8's whatsnew entry.


https://bugs.python.org/issue38206



Automerge-Triggered-By: @encukou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

+1 more reviewer

@eduardo-elizondo eduardo-elizondo eduardo-elizondo approved these changes

Assignees

@encukou encukou

@DinoV DinoV

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ammaraskar @eduardo-elizondo @miss-islington @bedevere-bot @encukou @DinoV @the-knights-who-say-ni