bpo-36876: Moved Parser/listnode.c statics to interpreter state.#16328
Conversation
ericsnowcurrently
left a comment
There was a problem hiding this comment.
mostly LGTM
I have left just a few small suggestions to consider.
Sorry, something went wrong.
You can add listnode or parser variable to avoid having to write "interp->parser.listnode". But for that, you need to name the structure in pycore_pystate.h. |
Sorry, something went wrong.
|
I'm not quite sure what you mean. The change was specifically to move those variables into the interpreter state rather than stand-alone variables, as they were previously. |
Sorry, something went wrong.
|
I suggest to add |
Sorry, something went wrong.
|
Ah, OK, I understand now :-) Not sure what an additional variable buys in this case. I agree, if readability were adversely affected, it would be worth doing. As it is, it seems readable enough. |
Sorry, something went wrong.
|
It was just a minor remark for readability. You're free to ignore it ;-) |
Sorry, something went wrong.
https://bugs.python.org/issue36876