◐ Shell
reader mode source ↗
Skip to content

bpo-11410: Standardize and use symbol visibility attributes across POSIX and Windows.#16347

Merged
vsajip merged 7 commits into
python:masterfrom
vsajip:visibility
Oct 15, 2019
Merged

bpo-11410: Standardize and use symbol visibility attributes across POSIX and Windows.#16347
vsajip merged 7 commits into
python:masterfrom
vsajip:visibility

Conversation

@vsajip

@vsajip vsajip commented Sep 24, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vsajip vsajip requested review from njsmith and vstinner September 24, 2019 04:34
@vsajip vsajip requested a review from pablogsal as a code owner September 24, 2019 04:35
@bedevere-bot

bedevere-bot commented Sep 24, 2019

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vsajip

vsajip commented Sep 24, 2019

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Sep 24, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vsajip

vsajip commented Sep 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

BTW I've no idea why GitHub thinks I've started a review of my own PR - I was only replying to Victor's comments, so it's not clear what happened. I can't seem to cancel my spurious review, either.

@vsajip

vsajip commented Sep 24, 2019

Copy link
Copy Markdown
Member Author

OK, refreshing the page seems to have got rid of my spurious review :-)

@vsajip

vsajip commented Oct 14, 2019

Copy link
Copy Markdown
Member Author

I'd like to merge this - I believe I've adequately addressed comments by both @vstinner and @ronaldoussoren - if there are any objections to merging, please let me know!

@pablogsal

pablogsal commented Oct 14, 2019

Copy link
Copy Markdown
Member

I would suggest checking with the buildbots before merging, as the pr is changing the autotools scripts.

@vsajip

vsajip commented Oct 14, 2019

Copy link
Copy Markdown
Member Author

Pushed this branch to buildbot-custom and looked at the results of the resulting builds. While there are some failures, none appear to be related to this change.

@pablogsal

pablogsal commented Oct 14, 2019

Copy link
Copy Markdown
Member

@vsajip Thanks for checking!

@vsajip vsajip merged commit 0b60f64 into python:master Oct 15, 2019
@vsajip vsajip deleted the visibility branch October 15, 2019 07:26
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vsajip
bpo-11410: Standardize and use symbol visibility attributes across PO… …
162aa77 
…SIX and Windows. (pythonGH-16347)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vsajip @shihai1991
bpo-11410: Standardize and use symbol visibility attributes across PO… …
56eb072 
…SIX and Windows. (pythonGH-16347)
@jd jd mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren left review comments

@njsmith njsmith Awaiting requested review from njsmith

@pablogsal pablogsal Awaiting requested review from pablogsal

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vsajip @bedevere-bot @pablogsal @vstinner @ronaldoussoren @the-knights-who-say-ni