◐ Shell
reader mode source ↗
Skip to content

bpo-38275: Fix test_ssl issue caused by GH-16386#16428

Merged
tiran merged 1 commit into
python:masterfrom
tiran:bpo-38275-fixup
Sep 26, 2019
Merged

bpo-38275: Fix test_ssl issue caused by GH-16386#16428
tiran merged 1 commit into
python:masterfrom
tiran:bpo-38275-fixup

Conversation

@tiran

@tiran tiran commented Sep 26, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue38275

@tiran
bpo-38275: Fix for pythonGH-16386 …
34992cf 
Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran added tests Tests in the Lib/test dir needs backport to 3.7 labels Sep 26, 2019
This was referenced Sep 26, 2019
Merged
Merged
@vstinner

vstinner commented Sep 26, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bpo-38275: Fix for GH-16386 #16428

Please mention at least test_ssl in the commit title when you merge this PR.

@tiran tiran changed the title bpo-38275: Fix for GH-16386 Sep 26, 2019
@tiran tiran merged commit 9f77268 into python:master Sep 26, 2019
@tiran tiran deleted the bpo-38275-fixup branch September 26, 2019 16:23
@miss-islington

miss-islington commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 26, 2019

Copy link
Copy Markdown

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9f77268f901cc3e8874e5042361520a0e482476a 3.8

@miss-islington

miss-islington commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

Sorry @tiran, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9f77268f901cc3e8874e5042361520a0e482476a 3.7

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@tiran
bpo-38275: Fix test_ssl issue caused by pythonGH-16386 (python#16428) …
59fa747 
Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tiran tiran

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni